Add macos arm64 (m series chip) support. #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we get this PR shipped 😄 |
|
Please merge this PR, please, please! |
|
Please can someone merge this 🙏 |
|
any progress? |
|
In case anyone is curious I'm able to get this package installed with: npm install ItsJustMeChris/node-speaker#masterI'm using it inside a VSCode extension. The audio plays but the VSCode extension crashes immediately afterwards. When I run it in a stand-alone test script (outside the extension) I see this in the console. [1] 40711 trace trap node testing.jsIf anyone has any ideas, let me know! I'm continuing to investigate. |
TooTallNate
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables compilation on m series chipsets for modern mac systems.
Tested with
node examples/sine.jsIssues referencing.
#177
#156
#172
#174