[https-proxy-agent] Slice the headers when parsing proxy server respo…

…nse (#212) Fixes #207.
TooTallNate · Jul 10, 2023 · 23fe1e3 · 23fe1e3 · vercel · Jul 10, 2023
1 parent b75b5fd
commit 23fe1e3
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/gentle-panthers-stare.md b/.changeset/gentle-panthers-stare.md
@@ -0,0 +1,5 @@
+---
+'https-proxy-agent': patch
+---
+
+Correct the header parsing logic to stop before the response content to avoid generating an exception.
diff --git a/packages/https-proxy-agent/src/parse-proxy-response.ts b/packages/https-proxy-agent/src/parse-proxy-response.ts
@@ -63,7 +63,7 @@ export function parseProxyResponse(
 				return;
 			}
 
-			const headerParts = buffered.toString('ascii').split('\r\n');
+			const headerParts = buffered.slice(0,endOfHeaders).toString('ascii').split('\r\n');
 			const firstLine = headerParts.shift();
 			if (!firstLine) {
 				socket.destroy();

diff --git a/packages/proxy/src/proxy.ts b/packages/proxy/src/proxy.ts
@@ -462,5 +462,5 @@ function requestAuthorization(
 		'Proxy-Authenticate': 'Basic realm="' + realm + '"',
 	};
 	res.writeHead(407, headers);
-	res.end();
+	res.end('Proxy authorization required');
 }