[agent-base] Allow for never relying on stack trace #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During an HTTP request, if `opts.protocol` is set, then use that to determine the `secureEndpoint` value. Coupling that with an explicitly set `agent.protocol` in the instance (essentially "locking" it for use with either `http` or `https` module), then the agent will _never_ rely on the stack trace. By default it will still rely on the stack trace to allow for agent instances to be used with either `http` or `https` modules. Also moved the internal props to an object using a symbol, instead of relying on underscore props. Fixes #158.
🦋 Changeset detectedLatest commit: b2df98c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During an HTTP request, if
opts.protocolis set, then use that to determine thesecureEndpointvalue. Coupling that with an explicitly setagent.protocolin the instance (essentially "locking" it for use with eitherhttporhttpsmodule), then the agent will never rely on the stack trace. By default it will still rely on the stack trace to allow for agent instances to be used with eitherhttporhttpsmodules.Also moved the internal props to an object using a symbol, instead of relying on underscore props.
Fixes #158.