Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mnemonic wizard: incorrect seed derivation during plaintext import to a satochip #12

Closed
Toporin opened this issue Mar 27, 2024 · 2 comments

Comments

@Toporin
Copy link
Owner

Toporin commented Mar 27, 2024

Description

When importing a (BIP39) mnemonic from the SeedKeeperTool wizard to a Satochip card (in plaintext), the mnemonic type is not identified correctly, and the wrong seed derivation algorithm (the one normally used for Electrum mnemonic). Consequently the addresses derived from the seed are not compatible with standard BIP39 as expected.

In summary, the SeedKeeperTool wizard derives BIP39 seeds using the Electrum algorithm.

Credits

Thanks to Telegram user Max Max for finding the bug and to @3rdIteration for confirming and reproducing the issue!

Toporin added a commit that referenced this issue Mar 27, 2024
The bug was caused by a wrong identification of the mnemonic type: Bip39 seed was identified as electrum seed in the wizard, thus the wrong derivation algorithm was used.
@Toporin
Copy link
Owner Author

Toporin commented Mar 27, 2024

fixed in f3eefb4

@Toporin Toporin closed this as completed Mar 27, 2024
@Toporin
Copy link
Owner Author

Toporin commented Mar 28, 2024

A python script has been released to recover a wallet affected by this issue (wallet derived from a BIP39 seed with the incorrect derivation algorithm):
https://github.com/Toporin/SeedkeeperTool-patch12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant