Add support for Apple Silicon #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottools
reviewed
May 10, 2021
| @@ -135,6 +135,8 @@ void tc_spinloop() | |||
| // Pause would do nothing on the Xbox. Threads are not scheduled. | |||
| #elif defined( _WIN64 ) | |||
| YieldProcessor( ); | |||
| #elif (defined( __arm64__ ) && defined( __APPLE__ )) || defined( __arch64__ ) | |||
| asm( "yield" ); | |||
There was a problem hiding this comment.
That does not look like a good idea. Need to use an OS specific yield function call in order to cause the scheduler to intentionally yield/swap out the current process/thread effectively.
There was a problem hiding this comment.
I'll replace it with pthread_yield()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for running natively on the M1 Mac processors.