Bug fixes and inverting some logic #5
Conversation
…hecking for an older value
…r than not having the incorrect value
… has been changed. otherwise it will not restart correctly
| @@ -30,17 +30,18 @@ while true; do | |||
| echo $pinterface is one we should be checking | |||
| # Check to see if we need to update the config file | |||
| echo Checking MTU for $pinterface | |||
| pmtu=$(grep $(($PTARGET-8)) /etc/ppp/peers/$pinterface) | |||
| pmtu=$(grep 'mtu $(($PTARGET))' /etc/ppp/peers/$pinterface) | |||
There was a problem hiding this comment.
look for mtu 1500 or whatever the PTARGET is instead of just PTARGET-8 (1492) because there is no guarantee that will actually be the value. also if someone has other changes with the same number somewhere else in this file that would cause problems. so i changed it to look for exactly the target mtu value. i assumed the mru would be the same which i think is fine.
I also made it look for the correct rather than the wrong because ptarget-8 is never going to be true if you have a ptarget of like 1444
| echo MTU already correct in /etc/ppp/peers/$pinterface | ||
| pmtucorrect=1 | ||
| sed -i 's/mtu\s[0-9]*/mtu '$PTARGET'/g' /etc/ppp/peers/$pinterface | ||
| sed -i 's/mru\s[0-9]*/mru '$PTARGET'/g' /etc/ppp/peers/$pinterface |
There was a problem hiding this comment.
instead of doing a ptarget-8 replacement i changed this to replace the number value of mtu and mru lines individually no matter what value they have. for aforementioned ptarget-8 problems
| @@ -50,7 +51,10 @@ while true; do | |||
| echo Got $emtu for $einterface | |||
| # Current ethernet MTU is incorrect so needs changing | |||
| echo Checking $einterface | |||
| if [[ $emtu -lt $(($PTARGET+8)) ]] ; then | |||
| if [[ $emtu -eq $(($PTARGET)) ]] ; then | |||
There was a problem hiding this comment.
changed this to look for the correct rather than the incorrect but that incorrect is not always right. it would only be right if you were trying to increase the mtu rather than decrease. which is what i want to do. so this works for both
| @@ -74,14 +75,14 @@ while true; do | |||
| if [ $pmtucorrect -eq 1 ] && [ $emtucorrect -eq 1 ]; then | |||
| # Config files are all correct | |||
| echo Config files are now all set correctly | |||
| runningmtu=$(ip link list | grep $pinterface | grep $(($PTARGET-8))) | |||
| if [ ! -z $runningmtu ]; then | |||
| runningmtu=$(ip link list | grep $pinterface | grep $(($PTARGET))) | |||
There was a problem hiding this comment.
get rid of the -8 check here and look for if it doesnt have the correct value instead of it having the specific wrong value
| pmtucorrect=1 | ||
| sed -i 's/mtu\s[0-9]*/mtu '$PTARGET'/g' /etc/ppp/peers/$pinterface | ||
| sed -i 's/mru\s[0-9]*/mru '$PTARGET'/g' /etc/ppp/peers/$pinterface | ||
| restartpppd=1 |
There was a problem hiding this comment.
i noticed when using this script that the ppp0 interface would have the wrong value after it worked, but the config would be correct. i realized it was because this was happening too soon, it needs to happen after the eth interface is updated. so i just set restartpppd=1 here and have pppd restart later instead of right away
I went to use this script to replace the one I wrote myself for this same MTU ppp problem. And when I went to do that I ran into some issues. I needed to set my MTU to 1444 which all of the "$PTARGET-8" checks failed against, so I removed them and inverted the logic in some places to check if things are in the desired state instead of checking if things are in a specific wrong state.
I am going to leave comments on the individual changes with more specifics.