Fix scenario properties form types #4210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mslabek
changed the title
…spill state fields
mslabek
changed the title
|
created: #4214 |
|
updated: #4214 |
JulianWielga
approved these changes
Apr 5, 2023
|
But what about validating it on the backend side? I think we should also validate it on the backend and return a nice message. |
arkadius
reviewed
Apr 7, 2023
| fieldProperty={"typeSpecificProperties.spillStateToDisk"} | ||
| validators={[errorValidator(fieldErrors || [], "spillStateToDisk")]} | ||
| fieldType={FieldType.select} | ||
| fieldLabel={"I/O mode"} |
There was a problem hiding this comment.
It shouldn't be done on FE, we should move this to BE, we already has options to do that. Let's talk
arkadius
requested changes
Apr 7, 2023
|
Thanks for feedback. I'm taking a new approach to this problem in line with your suggestions. The WIP PR: #4225 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typing a non-integer value in the parallelism or checkpoint interval properties resulted in an ugly looking backend unmarshalling error since backend expects an integer/long in these fields. There doesn't seem to be a way to get types and default values of type specific scenario properties without modifying the backend api. The simplest solution is to prevent the user from typing non-integers.
The form with new placeholders looks like this:
There is no feedback to the user when he tries to type a non-integer, but that is still preferable than throwing an ugly error.