Bump dependency versions that are grabbed transitively #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- httpclient:4.5.8 is included with gerrit-rest-java-client - commons-cli:1.4 is included with checkstyle (1.2 does not even have the DefaultParser that is used for the CLI) These versions are now explicitly defined, so build won't fail if the first level dependencies won't rely on them anymore.
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
=========================================
Coverage 72.38% 72.38%
Complexity 608 608
=========================================
Files 146 146
Lines 1988 1988
Branches 131 131
=========================================
Hits 1439 1439
Misses 489 489
Partials 60 60 Continue to review full report at Codecov.
|
|
Thank you! |
rufuslevi
pushed a commit
to rufuslevi/sputnik
that referenced
this pull request
Mar 12, 2024
- httpclient:4.5.8 is included with gerrit-rest-java-client - commons-cli:1.4 is included with checkstyle (1.2 does not even have the DefaultParser that is used for the CLI) These versions are now explicitly defined, so build won't fail if the first level dependencies won't rely on them anymore. Co-authored-by: Gabor Garancsi <gabor.garancsi@casrd.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1.2 does not even have the DefaultParser that is used for the CLI)
These versions are now explicitly defined, so build won't fail
if the first level dependencies won't rely on them anymore.