Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homogenise new column parameter in steps interfaces #464

Closed
wants to merge 1 commit into from

Conversation

vdestraitt
Copy link
Contributor

Closes #460

WARNING: This PR introduces a breaking change and requires a migration in client applications

@vdestraitt vdestraitt changed the title Homogenise new column parameter in steps interface Homogenise new column parameter in steps interfaces Mar 3, 2020
@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #464 into master will not change coverage.
The diff coverage is 97.36%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #464   +/-   ##
=======================================
  Coverage   96.72%   96.72%           
=======================================
  Files         121      121           
  Lines        2749     2749           
  Branches      397      397           
=======================================
  Hits         2659     2659           
  Misses         90       90
Impacted Files Coverage Δ
src/components/stepforms/schemas/rollup.ts 100% <ø> (ø) ⬆️
src/components/stepforms/PercentageStepForm.vue 94.11% <ø> (ø) ⬆️
src/lib/steps.ts 100% <ø> (ø) ⬆️
src/components/stepforms/schemas/formula.ts 100% <ø> (ø) ⬆️
src/components/stepforms/SubstringStepForm.vue 93.33% <ø> (ø) ⬆️
src/components/stepforms/schemas/text.ts 100% <ø> (ø) ⬆️
src/lib/labeller.ts 98.29% <100%> (ø) ⬆️
src/components/stepforms/AddTextColumnStepForm.vue 100% <100%> (ø) ⬆️
src/components/stepforms/schemas/dateextract.ts 100% <100%> (ø) ⬆️
src/components/stepforms/FormulaStepForm.vue 93.1% <100%> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d56b07...4136753. Read the comment docs.

@vdestraitt vdestraitt closed this Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make output column names consistent
1 participant