Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance Start and End Siege Events #401

Merged
merged 3 commits into from
Oct 31, 2021
Merged

Enhance Start and End Siege Events #401

merged 3 commits into from
Oct 31, 2021

Commits on Oct 31, 2021

  1. Enhance Start and End Siege Events 

    This PR adds more methods to the events thrown at start and end of
sieges.

It also adds a SiegeSide variable to Sieges: SiegeWinner.

Closes #400.
Whitespacing fixes.
    @LlmDl
    LlmDl committed Oct 31, 2021
    Configuration menu
    Copy the full SHA
    025fde8 View commit details
    Browse the repository at this point in the history

  2. Use translated SiegeType name in the start event.

    @LlmDl
    LlmDl committed Oct 31, 2021
    Configuration menu
    Copy the full SHA
    cb5766f View commit details
    Browse the repository at this point in the history

  3. Event variables set in contructor.

    @LlmDl
    LlmDl committed Oct 31, 2021
    Configuration menu
    Copy the full SHA
    1fef904 View commit details
    Browse the repository at this point in the history