Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pause when switching output channel #17

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

SammysHP
Copy link
Contributor

@SammysHP SammysHP commented Nov 7, 2023

This allows to select the maximum regulated level when ramping up or down.

ui/anduril/ramp-mode.c Outdated Show resolved Hide resolved
@SiteRelEnby
Copy link
Contributor

SiteRelEnby commented Nov 7, 2023

I feel like I'm missing what this actually does other than set and then decrement a variable - just adding a delay when ramping down? delay_zero() might be easier, but also this seems like it'd apply every single time the user ramps down rather than just if you meant e.g. on the border between a linear vs FET ramp segment?

@SammysHP
Copy link
Contributor Author

SammysHP commented Nov 7, 2023

This stops for HOLD_TIMEOUT when ramping up and down every time you cross the channel switchover. This allows the user to precisely select the maximum regulated level while ramping. Without it, BLINK_AT_RAMP_MIDDLE is pretty useless.

@ToyKeeper
Copy link
Owner

This is an interesting option, but I don't plan to enable it by default (i.e. in production builds). It seems more appropriate as a thing people can enable at compile time, like by setting a preference in users/$myuser/ so it'll apply to all their builds.

@SammysHP
Copy link
Contributor Author

SammysHP commented Nov 8, 2023

It's enough to comment out the line in config-default.h to make it optional. Should I update the pull request accordingly?

This allows to select the maximum regulated level when ramping up or
down.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants