Remove unused dependencies #1207
Conversation
There was a problem hiding this comment.
Reviewable status: 0 of 1 LGTMs obtained, and 0 of 11 files reviewed, and pending CI: Analyze (javascript-typescript), Analyze (python), Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Installation / macos-13, Installation / macos-14, Installation / ubuntu-22.04, Local / ubuntu-22.04, Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), integration-tests (20.04), integration-tests (22.04), macos-13, pre-commit-checks, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, vale, windows-2022 / stable (waiting on @aaronmondal)
There was a problem hiding this comment.
Mwahaha sneakily merged the hyper PR so I'm not the one that needs to rebase 😈
Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: 1 of 1 LGTMs obtained, and all files reviewed, and pending CI: Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Installation / macos-13, Installation / ubuntu-22.04, Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), windows-2022 / stable
allada
force-pushed
the
remove-unused-dependencies
branch
from
c5dc397
to
b172647
Compare
Cleanup some unused dependencies.
allada
force-pushed
the
remove-unused-dependencies
branch
from
b172647
to
e35a8b4
Compare
There was a problem hiding this comment.
All good, I've been forcing all of you to hold off and rebase on my changes lately, I'm ok taking turns 😛
Reviewable status: 1 of 1 LGTMs obtained, and 2 of 11 files reviewed, and pending CI: pre-commit-checks
There was a problem hiding this comment.
Reviewed 2 of 11 files at r1, 9 of 9 files at r2, all commit messages.
Reviewable status:complete! 1 of 1 LGTMs obtained, and all files reviewed
Fixes regression in Bazel functionality. Removes nativelink-proto as build dependency causing bazel builds to fail. This package was already removed from Cargo.toml in TraceMachina#1207.
Cleanup some unused dependencies.
This change is