Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ASAN error and enable ASAN in CI #187

Merged
merged 1 commit into from
Jul 16, 2023
Merged

Fix ASAN error and enable ASAN in CI #187

merged 1 commit into from
Jul 16, 2023

Conversation

allada
Copy link
Member

@allada allada commented Jul 16, 2023

Enables ASAN tests in CI and fixes the circular reference it found.


This change is Reviewable

Copy link
Member Author

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@aaronmondal

Reviewable status: 0 of 5 files reviewed, all discussions resolved (waiting on @aaronmondal)

Enables ASAN tests in CI and fixes the circular reference it found.
Copy link
Member

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Seems like i went into the wrong direction when trying to fix this 😆

I have a few small changes to tsan ready which seem to distill tsan issues down to 3 tests.

Addresses the Asan issues in #188
:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @allada)

Copy link
Member Author

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah any time you see unsafe your eyes immediately go "oh, that's the issue", but in reality any time unsafe is actually used it is usually really carefully thought about to make sure it really is safe.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @allada)

@allada allada merged commit e0cc0f9 into master Jul 16, 2023
@allada allada deleted the fix-asan-bugs branch July 16, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants