Fix nightly clippy warnings #817
Conversation
Using clippy for the nightly rust toolchain is currently warnings in a number of spots. This implements the suggested changes so that all builds will not suddenly start failing if the toolchain version used by precommit-hooks is updated.
zbirenbaum
requested review from
adam-singer,
aaronmondal,
blakehatch and
allada
There was a problem hiding this comment.
Reviewable status: 0 of 1 LGTMs obtained, and pending CI: Analyze (python), Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Local / ubuntu-22.04, Publish image, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), integration-tests (20.04), integration-tests (22.04), macos-13, pre-commit-checks, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, windows-2022 / stable, zig-cc ubuntu-20.04, zig-cc ubuntu-22.04, and 1 discussions need to be resolved
-- commits line 1 at r1:
As a side note, there is a similar issue with cargo fmt. Sometimes, cargo +nightly fmt will not change anything, and the precommit hooks will fail since cargo +stable fmt does change some things.
I was under the impression that bazel test //... is supposed to use the nightly version of rust but it seems that is currently not the case.
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: 1 of 1 LGTMs obtained, and 1 discussions need to be resolved
Implements suggested performance refactors and prevents future clippy warnings.
Description
Using clippy for the nightly rust toolchain is currently showing warnings in a number of spots. This implements the suggested changes so that all builds will not suddenly start failing if the toolchain version used by precommit-hooks is updated.
bazel test //...passes locallygit amendsee some docsThis change is