Update Vale CI action to handle large diffs
#978
Conversation
There was a problem hiding this comment.
Reviewable status: 0 of 1 LGTMs obtained, and pending CI: Analyze (javascript-typescript), Analyze (python), Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Installation / macos-13, Installation / macos-14, Installation / ubuntu-22.04, Local / ubuntu-22.04, Publish image, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), integration-tests (20.04), integration-tests (22.04), macos-13, pre-commit-checks, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, vale, windows-2022 / stable (waiting on @aaronmondal)
This PR helps us to avoid running into the issue described in reviewdog/reviewdog#1696, where diffs that are too large will cause Vale to fail The diff between the versions of Vale and the new one can be viewed [here](https://github.com/errata-ai/vale-action/compare/c99f2d..91ac40). Since they also allow you to specify which version of reviewdog to use, we'll use the most recent one which includes all the changes made so far that are supposed to fix the issue with large diffs.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 LGTMs obtained
Description
This PR helps us to avoid running into the issue described in
reviewdog/reviewdog#1696, where diffs that
are too large will cause Vale to fail
The diff between the versions of Vale and the new one can be viewed
here.
Since they also allow you to specify which version of reviewdog to use,
we'll use the most recent one which includes all the changes made so far
that are supposed to fix the issue with large diffs.
Type of change
Please delete options that aren't relevant.
How Has This Been Tested?
It hasn't, but we'll see how it runs on this PR.
Checklist
bazel test //...passes locallygit amendsee some docsThis change is