Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add and improve triggers UI #151

Merged
merged 19 commits into from
Jun 5, 2024
Merged

feat: Add and improve triggers UI #151

merged 19 commits into from
Jun 5, 2024

Conversation

daryllimyt
Copy link
Contributor

@daryllimyt daryllimyt commented Jun 5, 2024

Features

  • Workflows now come with only one Webhook by default
  • Introduce concept of Trigger, which include 1 Webhook and N Schedules
  • Added version badge to nav bar
  • Added new node type trigger with panel
    • Each trigger node can only have one outgoing edge
    • trigger node is created on workflow creation and cannot be deleted
  • Reinstate proper webhook authentication
  • Implement scaffolding for Schedule triggers

Improvements

  • Webhook copy button shows double tick for 2s after click
  • Improved data model for workflow source of truth reasoning
  • Better graph validation on commit (RFGraph)
  • Improved and cleaned up FE hooks
  • Imroved and cleaned up useWorkflow context
  • Improved BE incoming webhook validation
  • Improved user facing exceptions]
  • Reduce usage of toast across the app
  • Cleanup and simplify logic across the FE

Todo

  • Select the version and only execute the checked out version. Currently we just execute the latest version

Testing

  • Tested diamond pattern with slack with ngrok

Screenshot 2024-06-05 at 03 07 56

Copy link

vercel bot commented Jun 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tracecat ❌ Failed (Inspect) Jun 5, 2024 2:06am

@daryllimyt daryllimyt requested a review from topher-lo June 5, 2024 02:06
@daryllimyt daryllimyt self-assigned this Jun 5, 2024
@daryllimyt daryllimyt added the enhancement New feature or request label Jun 5, 2024
@topher-lo topher-lo merged commit 3c9f78b into main Jun 5, 2024
1 of 4 checks passed
@topher-lo topher-lo deleted the feat/triggers/webhook-ui branch June 5, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants