Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Run context propagation + revived case management #153

Merged
merged 5 commits into from
Jun 5, 2024

Conversation

daryllimyt
Copy link
Contributor

@daryllimyt daryllimyt commented Jun 5, 2024

Features

  • Added tracecat.contexts.ctx_run
  • Pass contextvars through workflow and activity args, as activities may be run on different workers (no longer threadlocal). The alternative is passing context through Temporal header interceptors, but appears to be more work.

Improvements

  • Revived case management
  • Fix propagation of ContextVars throughout Temporal workflows and workers (tested using case management)

Screenshot 2024-06-05 at 21 23 24

Copy link

vercel bot commented Jun 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tracecat ❌ Failed (Inspect) Jun 5, 2024 8:22pm

@daryllimyt daryllimyt requested a review from topher-lo June 5, 2024 20:22
@daryllimyt daryllimyt added enhancement New feature or request engine Improvements or additions to the workflow engine fix Bug fix labels Jun 5, 2024
@daryllimyt daryllimyt self-assigned this Jun 5, 2024
@daryllimyt daryllimyt merged commit 82d45ee into main Jun 5, 2024
1 of 2 checks passed
@daryllimyt daryllimyt deleted the fix/run-context-propagration branch June 5, 2024 20:26
@daryllimyt daryllimyt changed the title fix: Run context propagation fix: Run context propagation + revived case management Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine Improvements or additions to the workflow engine enhancement New feature or request fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant