Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(engine+ui): Add Datadog security signals actions #68

Merged
merged 8 commits into from
Apr 20, 2024
Merged

feat(engine+ui): Add Datadog security signals actions #68

merged 8 commits into from
Apr 20, 2024

Conversation

topher-lo
Copy link
Contributor

@topher-lo topher-lo commented Apr 19, 2024 •
edited
Loading

Closes part of tracker issue #67

Note: still untested. Requires an AWS-Datadog lab environment (with stratus-red-team to generator signals).

  • Integration and action form shows up correctly in frontend
dd_integrations
  • Confirmed type hints to UI works
image
  • Confirm form saves and state shows up in JSON viewer

@topher-lo topher-lo added engine Improvements or additions to the workflow engine integration Pre-built actions labels Apr 19, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tracecat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 20, 2024 3:29pm

@github-actions github-actions bot added the enhancement New feature or request label Apr 19, 2024
@topher-lo topher-lo self-assigned this Apr 20, 2024
@topher-lo topher-lo changed the title feat(engine): Add Datadog security signals actions feat(engine+ui): Add Datadog security signals actions Apr 20, 2024
@github-actions github-actions bot added the frontend Improvements or additions to the frontend label Apr 20, 2024
daryllimyt
daryllimyt requested changes Apr 20, 2024
View reviewed changes
Copy link
Contributor

@daryllimyt daryllimyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typing additions, LGTM. Final check - do the UI form elements show up correctly?

tracecat/integrations/datadog.py Outdated Show resolved Hide resolved
tracecat/integrations/datadog.py Outdated Show resolved Hide resolved
@daryllimyt daryllimyt merged commit 0e46527 into main Apr 20, 2024
3 checks passed
@daryllimyt daryllimyt deleted the integration/datadog-signals branch April 20, 2024 16:09
topher-lo added a commit that referenced this pull request May 4, 2024
@topher-lo @daryllimyt
feat(engine+ui): Add Datadog security signals actions (#68)
97027db 
Co-authored-by: Daryl Lim <5508348+daryllimyt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daryllimyt daryllimyt Awaiting requested review from daryllimyt

Assignees

@topher-lo topher-lo

Labels
engine Improvements or additions to the workflow engine enhancement New feature or request frontend Improvements or additions to the frontend integration Pre-built actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@topher-lo @daryllimyt