Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement prod and prod_dim for WGPU backend #1461

Closed
antimora opened this issue Mar 11, 2024 · 1 comment · Fixed by #1474
Closed

Implement prod and prod_dim for WGPU backend #1461

antimora opened this issue Mar 11, 2024 · 1 comment · Fixed by #1474
Assignees
@louisfd
Labels
wgpu Related to WGPU backend

Comments

@antimora
Copy link
Collaborator

Currently default unoptimized implementation is used for float tensor. To use with int tensor, one should convert to float (tensor.float()) and use prod or prod_dim methods.
@antimora antimora added the wgpu Related to WGPU backend label Mar 11, 2024
@antimora antimora mentioned this issue Mar 11, 2024
Merged
2 tasks
@louisfd louisfd self-assigned this Mar 12, 2024
@louisfd
Copy link
Member

louisfd commented Mar 12, 2024

It will be very easy, by adding a ProdDim trait for Reduce in burn-jit. It will work for float and int + be autotunable

@louisfd louisfd mentioned this issue Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@louisfd louisfd

Labels
wgpu Related to WGPU backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate/jit/prod tracel-ai/burn
2 participants
@antimora @louisfd