Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Simplify CI binaries updating #1235

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Feb 2, 2024

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Changes

  • Use latest keyword instead of a specific tag for the binaries that allow this trick
  • Move the version variable at the top of the yml files, so it's simpler to update their versions

Copy link
Member

@syl20bnr syl20bnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's always pin a version when we can.

.github/workflows/test.yml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9df2071) 84.41% compared to head (a427a6e) 84.38%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1235      +/-   ##
==========================================
- Coverage   84.41%   84.38%   -0.03%     
==========================================
  Files         549      549              
  Lines       61952    61954       +2     
==========================================
- Hits        52295    52281      -14     
- Misses       9657     9673      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nathanielsimard nathanielsimard merged commit a99258d into tracel-ai:main Feb 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants