Upgrade to Rails 4.2 #1910
Upgrade to Rails 4.2 #1910
Conversation
|
Letting Travis do the testing work for me. :-) Still needs some work -- closing until I revisit. |
dnrce
force-pushed
the
rails42
branch
2 times, most recently
from
d0dca3a
to
2baff2a
Compare
|
I'm puzzled by the failures of |
|
Looks like some tests are still failing. Are those legit errors that we should try and fix? |
|
These are legit issues. Some are only with the tests themselves. The URL whitelist issue also needs to be addressed. I reopened this so I could push some rebased changes, and to get more eyes on it. Not ready to merge. |
|
Opened rails/rails-dom-testing#42 regarding the |
|
Can we get a rebase on this? I'm rerunning the tests on this locally and would love to merge it soon. If it's not something that you can get to soon, I can pull it locally and rebase it. |
|
Updated. I had a few test changes in my local branch so this might not be 100% up to date, but it resolves the conflict. Still not passing. |
dnrce
force-pushed
the
rails42
branch
2 times, most recently
from
7fe6ab4
to
ec71b16
Compare
Support Rails 4.2
dnrce
force-pushed
the
rails42
branch
2 times, most recently
from
0baafa8
to
bf68bac
Compare
|
Filed another bug against rails-dom-testing that is causing |
|
|
dnrce
force-pushed
the
rails42
branch
2 times, most recently
from
230cf87
to
0fccdd7
Compare
|
After fighting through/working around all the annoying behavior changes in
It's only taken me nine months. But hey, I beat the release of Rails 5. 😄 |
|
Actually, doing a little bit of squashing.. |
* Update boilerplate with `bin/rake rails:upgrade` * Use test instead of test:all rake task * Change stylesheet extensions from .css.scss to .scss * Update docs to use localhost instead of 0.0.0.0 because Rails 4.2 no longer listens on all addresses by default.
assert_select has been moved into the rails-dom-testing gem and is now based on Nokogiri. * Remove assert_tag and assert_xml_select * Quote CSS attribute selector values * Use decoded versions of HTML in assert_select. Nokogiri decodes elements prior to matching. * Add a test helper for entities such as ` ` for which it's difficult or confusing to include the decoded version directly in the assertion. * Assert directly on Atom feeds' XML namespace because it isn't selectable as an attribute
|
Squashed from 16 to 8 commits. |
|
Cool. Thanks for working on this! I'll take a look soon. On Sun, May 22, 2016 at 9:07 PM, Dan Rice notifications@github.com wrote:
|
|
@mattr-, any chance to review this yet? I'm just hoping to get this in before Rails 5 makes this officially obsolete. 😄 |
| @@ -27,6 +27,10 @@ | |||
| # number of complex assets. | |||
| config.assets.debug = true | |||
|
|
|||
| # Asset digests allow you to set far-future HTTP expiration dates on all assets, | |||
| # yet still be able to expire them through the digest params. | |||
| config.assets.digest = true | |||
There was a problem hiding this comment.
i'm not sure we want to enable digests in development mode, do we?
There was a problem hiding this comment.
It's to provide better parity between environments. See rails/rails#15155
|
This looks good to me. |
|
Forgot to merge this the other day. 😞 |
|
Woohoo! Thanks, @mattr-! |
Resolves #1775