Skip to content

Conversation

marciomazza
Copy link
Contributor

This was necessary to authenticate with a different username/password in the upstream (using basic auth).
I imagine it can be useful in other circumstances.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling af1ec6c on interlegis:master into 3bd895d on TracyWebTech:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling af1ec6c on interlegis:master into 3bd895d on TracyWebTech:master.

@seocam
Copy link
Contributor

seocam commented May 18, 2015

This can indeed be useful! I would just change the name of the method to get_proxy_request_headers because it will be called every time and I would also move lines 62-66 to inside the method (since they are related to headers).

Also needs docs and tests.

@marciomazza
Copy link
Contributor Author

@seocam
Copy link
Contributor

seocam commented May 18, 2015

@marciomazza that's it! My reference became outdated by a merged PR. ;)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 53ef4ac on interlegis:master into ed984ee on TracyWebTech:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 53ef4ac on interlegis:master into ed984ee on TracyWebTech:master.

seocam added a commit that referenced this pull request May 18, 2015
Add extension point for custom header adjustments
@seocam seocam merged commit f3e5853 into jazzband:master May 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants