Set to do not escape unreserved characters

[chocoelho]

No description provided.

[coveralls]

Coverage remained the same at 100.0% when pulling 87d18a0 on carloshfoliveira:unreserved_safe into 3bd895d on TracyWebTech:master.

[seocam]

Cool! Tests should be implemented on test_request.py instead of test_views.py.

[chocoelho]

Yeah, but we thought that since the changes we made were on views.py, implementing them on test_views.py made sense.

[seocam]

Nginx currently ONLY escape: " ", "#", "%", "?", "\x1F", "\x7F"
Apache HTTP Server DON'T escape: $-_.+!*'(),:@&=/~"

Currently we are doing to none of those. I'm working on finding a good set of chars.

[chocoelho]

So, the best approach will be defining another charset instead of the unreserved ones that might cover both cases?

[seocam]

@carloshfoliveira the best approach is the one you used. ;) I'm just concerned about which strings we should consider to be safe.

[seocam]

@carloshfoliveira let's go for nginx implementation.

Instead of defining the unreserved inside the class it's better to create a constant QUOTE_SAFE just after the imports and use it on the quote function.

QUOTE_SAFE = '<.;>\(}*+|~=-$/_:^@)[{]&\'!,"'`

This is basically string.punctuation without #, ? and %.

You can also use this link as reference instead of the RFC: https://github.com/nginx/nginx/blob/nginx-1.9/src/core/ngx_string.c#L1433-L1449

[coveralls]

Coverage remained the same at 100.0% when pulling bc07ce1 on carloshfoliveira:unreserved_safe into 3bd895d on TracyWebTech:master.

[coveralls]

Coverage remained the same at 100.0% when pulling 68c3f1e on carloshfoliveira:unreserved_safe into 3bd895d on TracyWebTech:master.

[coveralls]

Coverage remained the same at 100.0% when pulling 68c3f1e on carloshfoliveira:unreserved_safe into 3bd895d on TracyWebTech:master.