support latest urllib3 version

[aausch]

I believe this fixes #75

Note that pool.py has not been necessary since urllib3==1.6 (and minimum is now 1.12, much higher than that) --> see urllib3/urllib3@9570cd2

[coveralls]

Coverage remained the same at 100.0% when pulling 421a2ff on aausch:master into 4da98bd on TracyWebTech:master.

[coveralls]

Coverage remained the same at 100.0% when pulling a4e5562 on aausch:master into 4da98bd on TracyWebTech:master.

[coveralls]

Coverage decreased (-0.3%) to 99.73% when pulling c28b68e on aausch:master into 4da98bd on TracyWebTech:master.

[coveralls]

Coverage remained the same at 100.0% when pulling e5f4438 on aausch:master into 4da98bd on TracyWebTech:master.

[coveralls]

Coverage remained the same at 100.0% when pulling 830c41d on aausch:master into 4da98bd on TracyWebTech:master.

[aausch]

Note that pool.py has not been necessary since urllib3==1.6 (and minimum is now 1.12, much higher than that) --> see urllib3/urllib3@9570cd2

[coveralls]

Coverage remained the same at 100.0% when pulling c89882f on aausch:master into 4da98bd on TracyWebTech:master.

[coveralls]

Coverage remained the same at 100.0% when pulling c89882f on aausch:master into 4da98bd on TracyWebTech:master.

[coveralls]

Coverage remained the same at 100.0% when pulling bee8fee on aausch:master into 4da98bd on TracyWebTech:master.

[aausch]

@seocam mind taking a look/merging?

[seocam]

Sorry @aausch I'm gonna work on that next week!

[msfernandes]

@seocam there is any prevision to review this PR?

[seocam]

Hey @msfernandes. I've just gave you write access to the repo. Feel free to do and/or ask for modifications before merging anything.

[brianmay]

This patch breaks the tests. Yes, I know Travis tests pass, not sure why. Investigating.

[brianmay]

This change also now required:

diff --git a/tests/test_transformer.py b/tests/test_transformer.py
index 3ef0bbc..1db063d 100644
--- a/tests/test_transformer.py
+++ b/tests/test_transformer.py
@@ -110,6 +110,7 @@ class TransformerTest(TestCase):
         test_file = MockFile(FILE_CONTENT, 4)
         mock_file = MagicMock()
         type(mock_file).encoding = PropertyMock(return_value='utf-8')
+        type(mock_file).isclosed = MagicMock(side_effect=test_file.closed)
         type(mock_file).closed = PropertyMock(side_effect=test_file.closed)
         mock_file.read.side_effect = test_file.read
         mock_file.close.side_effect = test_file.close
@@ -137,6 +138,7 @@ class TransformerTest(TestCase):
 
         mock_file = MagicMock()
         type(mock_file).encoding = PropertyMock(return_value='utf-8')
+        type(mock_file).isclosed = MagicMock(side_effect=test_file.closed)
         type(mock_file).closed = PropertyMock(side_effect=test_file.closed)
         mock_file.read.side_effect = test_file.read
         mock_file.close.side_effect = test_file.close

The problem is urllib3/util/response.py function is_fp_closed now checks obj.isclosed before obj.closed and can get confused when it gets a mock object and incorrectly returns True, preventing further reads from the file.

[brianmay]

Fixed in #88.