✨ add friend checkin to api #2717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have received a request to add an expiry date for trusted users, e.g. to use this for time-limited trips. |
HerrLevin
reviewed
Jul 3, 2024
HerrLevin
requested changes
Jul 5, 2024
HerrLevin
requested changes
Jul 13, 2024
Co-authored-by: Levin Herr <github@17d.me>
Co-authored-by: Levin Herr <github@17d.me>
Co-authored-by: Levin Herr <github@17d.me>
# Conflicts: # app/Http/Controllers/API/v1/SettingsController.php # app/Http/Controllers/API/v1/TransportController.php # app/Models/User.php # resources/views/includes/status.blade.php # storage/api-docs/api-docs.json
HerrLevin
force-pushed
the
dev-ks/friend-checkin
branch
from
9d2713f
to
e062656
Compare
|
@MrKrisKrisu Hab's behoben/gemerged. Aber bitte teste dein feature einmal manuell durch, ob alles passt. Und auch ob ich nicht aus versehen was von dir beim Konflikte beheben gelöscht hab |
Danke. Von meiner Seite aus passt alles noch. |
HerrLevin
requested changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Added a new UserSettings to specify who is allowed to checking in for a user (forbidden, friends, list)
friends = following each other
list = see "trusted users" below
2. New Attribute on Checkin-Endpoint "with"
3. New Endpoints to manage "trusted users"
Trusted Users are only required, if User allow a specific list of trusted users to check in for them.
