Fix Array in useStore (v10.0.1) #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRJurman
commented
Feb 8, 2021
| @@ -10,7 +10,7 @@ const observableHook = require('./observable-hook') | |||
| * it will cause only the components that are dependent on that value to update. | |||
| * | |||
| * @param {string} key a unique string to write and read the global value | |||
| * @param {Object|Array} value the default value to start the state at | |||
| * @param {Object|Array} defaultValue the default value to start the store at | |||
There was a problem hiding this comment.
also taking this opportunity to change the parameter jsdoc here, it should be default value, as that is what it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the release of v10, the ability to store arrays was broken (because to make a shallow copy, the spread syntax for objects was used, but this inadvertently changed arrays to objects). There was no regression test for this, so a new one has been added.
Checklist