Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to ignore "Tailwind config not found" Error Message #11

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

kyaruwo
Copy link

@kyaruwo kyaruwo commented Jan 5, 2024

No description provided.

@kyaruwo kyaruwo changed the title option to ignore "Tailwind config not found" option to ignore "Tailwind config not found" Error Message Jan 5, 2024
@Trapfether
Copy link
Owner

Hello @kyaruwo, Thank you for this PR!

There are two things I would like to address and then I'll merge this with a patch version.

First, in the src/index.mjs file where you have added the conditional check, please refactor so that only the error message itself is skipped by the check. The early return inside the original if statement is necessary as the tailwind reorder can't function without finding the tailwind config. If you skip the early return, then it'll reintroduce #4

The other thing would be to add a short blurb to the Readme detailing the option.

If you're too busy to make these changes, I understand and I'll address this issue in my upcoming release.

If you have any questions, please let me know!

@Trapfether Trapfether merged commit 772dd62 into Trapfether:master Jan 25, 2024
@Trapfether
Copy link
Owner

@kyaruwo Thank you for putting in your time to help make this plugin better. I appreciate the help!

@Trapfether
Copy link
Owner

Going live with today's update. Please update to get the newest version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants