-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shrink unsafe
block in utils::from_lpstr()
#40
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! You can shrink one of the blocks even further :)
Would you mind also updating the commit title to match the PR title?
unsafe
block in utils::from_lpstr()
Thanks for the suggestion. |
What does 0503 mean? |
|
Commits already have a date associated with them :) If I may ask, why not put the pull request title in the commit title? |
And what's with |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switching this to an approval, but it'd be nice to shrink more unsafe
blocks while at it (if we didn't already do so in other PRs).
No description provided.