Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink unsafe block in utils::from_lpstr() #40

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

peamaeq
Copy link

@peamaeq peamaeq commented May 3, 2022

No description provided.

Copy link
Member

@MarijnS95 MarijnS95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! You can shrink one of the blocks even further :)

Would you mind also updating the commit title to match the PR title?

src/utils.rs Outdated Show resolved Hide resolved
src/utils.rs Outdated Show resolved Hide resolved
@MarijnS95 MarijnS95 changed the title Shrink unsafe block for the from_lpstr function Shrink unsafe block in utils::from_lpstr() May 3, 2022
@peamaeq
Copy link
Author

peamaeq commented May 3, 2022

谢谢!您可以进一步缩小其中一个块:)

你介意更新提交标题以匹配 PR 标题吗?

Thanks for the suggestion.

@peamaeq peamaeq requested a review from MarijnS95 May 3, 2022 11:25
@MarijnS95
Copy link
Member

What does 0503 mean?

@peamaeq
Copy link
Author

peamaeq commented May 3, 2022

What does 0503 mean?
3 May😊

@MarijnS95
Copy link
Member

Commits already have a date associated with them :)

If I may ask, why not put the pull request title in the commit title?

@MarijnS95
Copy link
Member

MarijnS95 commented May 3, 2022

And what's with from_lpstr() specifically? There seem to be more code blocks around that could get the same treatment.

@peamaeq
Copy link
Author

peamaeq commented May 3, 2022

And what's with from_lpstr() specifically? There seem to be more code blocks around that could get the same treatment.
Yes, utils::from_bstrcan also treat the same.🙌

Copy link
Member

@MarijnS95 MarijnS95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching this to an approval, but it'd be nice to shrink more unsafe blocks while at it (if we didn't already do so in other PRs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants