Import SLRT support for secure launch #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinit_acm_base -> dce_base sinit_acm_size -> dce_size "sinit_acm" is Intel-specific. DCE stands for Dynamic Configuration Environment and ACM is considered to be a DCE. Signed-off-by: Ross Philipson <ross.philipson@oracle.com> Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
SergiiDmytruk
force-pushed
the
intel-txt-aem-slrt
branch
from
366d53c
to
5643097
Compare
SergiiDmytruk
commented
Oct 12, 2023
There was a problem hiding this comment.
I didn't squash commits yet so it's easier to see differences. See https://github.com/TrenchBoot/grub/compare/366d53cf8f4cb9af5aa01508ded0564b5357f70d..f18f1e3be for changes in top commit and d6d6a8d with 5643097 for larger changes.
There are no more gaps or fixed size of policy entries. Things are added to the list dynamically from different places. This required making callers of grub_txt_boot_prepare() responsible for finishing building SLRT.
SergiiDmytruk
force-pushed
the
intel-txt-aem-slrt
branch
from
5643097
to
d87efc0
Compare
Provide definitions of structures and basic functions for constructing and parsing of SLRT. Signed-off-by: Ross Philipson <ross.philipson@oracle.com> Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
SergiiDmytruk
force-pushed
the
intel-txt-aem-slrt
branch
from
d87efc0
to
d45cdd1
Compare
Signed-off-by: Ross Philipson <ross.philipson@oracle.com> Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
SergiiDmytruk
force-pushed
the
intel-txt-aem-slrt
branch
from
d45cdd1
to
d77df30
Compare
krystian-hebel
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses TrenchBoot/trenchboot-issues#17
Commits were cherry-picked according to TrenchBoot/trenchboot-issues#17 (comment) with minor modifications where necessary (bugs, typos, compilation warnings/errors).
grub-sl-fc-38-dlstubcontains several more patches related to code reorganization and EFI, these were not included.The changes weren't tested.