Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sizes and order of SLRT fields #21

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

SergiiDmytruk
Copy link
Member

This aligns SKL with changes from TrenchBoot/linux#119.

This results in 64-bit alignment of 64-bit fields.

Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Copy link
Collaborator

@rossphilipson rossphilipson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compared this to the latest v9 SLRT and it looks good. So for that part:
Reviewed-by: Ross Philipson ross.philipson@oracle.com

There is a failed automatic test but I don't really know what it is for. If it does not prevent merging this PR, I will do it.

@krystian-hebel
Copy link
Collaborator

The failing "check" was actually a builder for RPM packages for QubesOS, it broke because of fepitre/qubes-builderv2@345f027 (which we used because of poor understanding of the builder and its imperfect documentation). At some point we will have to fix it, but as it isn't caused by this PR I think it is safe to merge.

@rossphilipson
Copy link
Collaborator

The failing "check" was actually a builder for RPM packages for QubesOS, it broke because of fepitre/qubes-builderv2@345f027 (which we used because of poor understanding of the builder and its imperfect documentation). At some point we will have to fix it, but as it isn't caused by this PR I think it is safe to merge.

Ack, that sounds reasonable. Will merge.

@rossphilipson rossphilipson merged commit ac26ede into shrink_measured_size Aug 12, 2024
56 of 57 checks passed
@SergiiDmytruk SergiiDmytruk deleted the update-slrt branch August 12, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants