Readability

[Trenly]

@OfficialEsco I haven't fully tested this yet, but I'm 90% sure it will work.

I added a function just to make things more readable.

String.IsValid {String} [-MinLength] [-MaxLength] [-MatchPattern]
  Returns True if and only if
    - String.Length >= MinLength  AND
    - String.Length <= MaxLength AND
    - String -match MatchPattern

I also did abstract everything to a hashtable just to keep things readable and for making future updates easier

[OfficialEsco]

Hahaha you just do the things don't you, glad you find inspiration in my ideas 😁
Sure it does kinda look better 🙄

From looking at the code you might have broken the $Max variable on line 591, 596, 601 and 606.

FileExtensions also have a Pattern, but i don't think we can implement it as its multi string?

Edit: Yupp

[Optional] Enter any File Extensions the application could support. For example: html, htm, url (Max )
FileExtensions:

[Optional] Enter any Protocols the application provides a handler for. For example: http, https (Max )
Protocols:

[Optional] Enter any Commands or aliases to run the application. For example: msedge (Max )
Commands:

[Optional] List of additional non-zero installer success exit codes other than known default values by winget (Max )
InstallerSuccessCodes:

[Trenly]

Hahaha you just do the things don't you, glad you find inspiration in my ideas 😁
Sure it does kinda look better 🙄

From looking at the code you might have broken the $Max variable on line 591, 596, 601 and 606.

FileExtensions also have a Pattern, but i don't think we can implement it as its multi string?

Edit: Yupp

[Optional] Enter any File Extensions the application could support. For example: html, htm, url (Max )
FileExtensions:

[Optional] Enter any Protocols the application provides a handler for. For example: http, https (Max )
Protocols:

[Optional] Enter any Commands or aliases to run the application. For example: msedge (Max )
Commands:

[Optional] List of additional non-zero installer success exit codes other than known default values by winget (Max )
InstallerSuccessCodes:

Oop; Should be an easy fix. I’ll do it when I get home.

We could probably do file extensions enum, I think we already do something similar for Architecture

Edit: Misread what you meant by multistring; Might still be possible though

[OfficialEsco]

We could probably do file extensions enum, I think we already do something similar for Architecture

There is no enum for FileExtensions, however we should probably start looking at error messages so it shows why it failed..

"FileExtensions": {
      "type": [ "array", "null" ],
      "items": {
        "type": "string",
        "pattern": "^[^\\\\/:\\*\\?\"<>\\|\\x01-\\x1f]+$",
        "maxLength": 64
      },
      "maxItems": 256,
      "uniqueItems": true,
      "description": "List of file extensions the package could support"
    }

},
        "Architecture": {
          "type": "string",
          "enum": [
            "x86",
            "x64",
            "arm",
            "arm64",
            "neutral"
          ],
          "description": "The installer target architecture"
        }

Edit:
We can probably look into enum for InstallModes first, might be a easier path to finding out how to do pattern for FileExtensions

"InstallModes": {
      "type": [ "array", "null" ],
      "items": {
        "title": "InstallModes",
        "type": "string",
        "enum": [
          "interactive",
          "silent",
          "silentWithProgress"
        ]
      },

Edit2: AHHH yeah you need to look into the MaxItems issue because last time i tried it your PromptInstallerManifestValue function restricted me

[Trenly]

Edit2: AHHH yeah you need to look into the MaxItems issue because last time i tried it your PromptInstallerManifestValue function restricted me

What do you mean?

[OfficialEsco]

Edit2: AHHH yeah you need to look into the MaxItems issue because last time i tried it your PromptInstallerManifestValue function restricted me

What do you mean?

The current issue is that you can't do Write-Host "Text here $Variable.MaxItems" you have to do Write-Host "Text here", $Variable.MaxItems but it got errors when i did that

[Trenly]

Edit2: AHHH yeah you need to look into the MaxItems issue because last time i tried it your PromptInstallerManifestValue function restricted me

What do you mean?

The current issue is that you can't do Write-Host "Text here $Variable.MaxItems" you have to do Write-Host "Text here", $Variable.MaxItems but it got errors when i did that

The $( ) operator is really helpful

[OfficialEsco]

Interesting.. learned something new, now i know the proper use for @( ) and $( ) 👀

[Trenly]

We could probably do file extensions enum, I think we already do something similar for Architecture

There is no enum for FileExtensions, however we should probably start looking at error messages so it shows why it failed..

"FileExtensions": {
      "type": [ "array", "null" ],
      "items": {
        "type": "string",
        "pattern": "^[^\\\\/:\\*\\?\"<>\\|\\x01-\\x1f]+$",
        "maxLength": 64
      },
      "maxItems": 256,
      "uniqueItems": true,
      "description": "List of file extensions the package could support"
    }

Edit:
We can probably look into enum for InstallModes first, might be a easier path to finding out how to do pattern for FileExtensions

"InstallModes": {
      "type": [ "array", "null" ],
      "items": {
        "title": "InstallModes",
        "type": "string",
        "enum": [
          "interactive",
          "silent",
          "silentWithProgress"
        ]
      },

I think I took care of this validation. I don't have it removing duplicate extensions though. Maybe that's something to look at later. I agree that error messages should be next

[OfficialEsco]

Was going to report a issue with the InstallModes but then i realized it was a typo, so it clearly works 😁
Probably not getting to stresstest before next week as there are way too few packages on the weekend

[OfficialEsco]

@quhxl since you go trough more packages than only GitHub releases and add Metadata would you mind testing this?
Not sure if you've updated/tested the YamlCreate since you've been gone for a few days, we appreciate any feedback :)