Begin Handling Manifest Level Parameters #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trenly
force-pushed
the
ManifestLevelParams
branch
from
b7c3678
to
fe7c0e0
Compare
|
Whoa, i thought i could force a issue but it worked as expected O_O However i found another part of the script that got broken in one of the last patches, when updating with option 1 it failed to read the InstallModes |
As in, forgot to read the existing value, or forgot to request them, or forgot to write it to file? |
|
AFAIK option 1 fails to read the existing InstallModes value |
Took a while to find the issue, but I found it. Should be fixed now |
|
Upon further consideration; The refactor for updating in place isn't of high priority and will take some time; I think that resolving this bug is too important to hold for the UpdateInPlace @OfficialEsco If you could give this a few cycles, I'd like to make 100% sure this doesn't introduce any new bugs before merging |
|
It is off-topic but I would suggest adding a comment like this so that moderators would know which mode was used while creating manifests and also, it will make it easier to suggest changes if a manifest contains wrong information. |
|
I have used it in my last 20+ PRs and it works fine. |
OfficialEsco
approved these changes
Sep 20, 2021
Trenly
added a commit
that referenced
this pull request
Sep 27, 2021
* Begin Handling Manifest Level Parameters * Fix InstallModes
Trenly
added a commit
that referenced
this pull request
Oct 13, 2021
* Begin Handling Manifest Level Parameters * Fix InstallModes
Trenly
added a commit
that referenced
this pull request
Nov 3, 2021
* Install powershell-yaml * Enforce ordering of keys * Create function for adding list parameters * Write Version Manifest using Yaml Parser * Add To-Do Section * Rebase on master and cleanup commit history * Revert inadvertent changes from testing * Implement logic for installers using YAML parser * Fix statement in incorrect position * Remove RAW writing * Begin reading MultiManifests using Yaml parser * Cleanup unneeded variables * Bump Version * Read parameters from singletons * Add Product Code * Abstract ReadInstallerManifest to sub-function * Fix: Handle uninitialized variables * Merge New/Update, add EditMetadata * Fix: Change EditMetadata to work on singleton manifests * Fix: Update Git commit messages for accuracy * Remove Empty Manifest Folders * Fix: Correct text * Fix: Remove code for testing * Feature: If old manifests exist, update in place to preserve extra keys * Fix: Null Error when creating new * Fix: Cast only when installer code * Fix: Respect installer locale * Fix: Use UTF8 Encoding * Sort Yaml Keys * Git error handling * Fixed Moniker prompt for NewLocale * minItems, maxItems, pattern, variable fix * Implemented minItems from Schema * Implemented maxItems from Schema * Implemented pattern from Schema * Implemented available Architecture's from Schema * Implemented available InstallerType's from Schema * Added $script: to some variables which needs to stay throughout the script Only tested with one manifest as of now Cleanup If/Else logic & Rebase on master * Update method of getting Product Code from installer * SignatureSha256 and PackageFamilyName (#5) * More CommitTypes * Fill in PR Parameters microsoft#21940 (#4) * Detect PackageFamilyName for MSIX/APPX (#8) * Update YamlCreate.ps1 * Update YamlCreate.ps1 * Exclude .validation (#9) * Exclude .validation * Added exclude to ExistingVersions Co-authored-by: Levvie - she/her <11600822+ItzLevvie@users.noreply.github.com> * Add new line for PackageFamilyName (#10) * Standardize Keypress Menus (#11) * Standardize Keypress Menus * Fix: Use variable instead of pipeline * Fix Help Texts & Spacing * Cleanup Git Messages * Filter by Yaml * Remove debugging line Co-authored-by: Esco <OfficialEsco@users.noreply.github.com> Co-authored-by: Kaleb Luedtke <kaleb.carver.luedtke@jci.com> Co-authored-by: Esco <OfficialEsco@users.noreply.github.com> * Replaced PrBodyContentReply `n with array (#12) * Menu reduction (#13) * Simplify Code + Make Issues Entry Safer * Check issue validity * Fix unintended Revert Co-authored-by: Esco <OfficialEsco@users.noreply.github.com> * Fix unintended Revert Co-authored-by: Esco <OfficialEsco@users.noreply.github.com> * Fix unintended Revert Co-authored-by: Esco <OfficialEsco@users.noreply.github.com> Co-authored-by: Esco <OfficialEsco@users.noreply.github.com> * More patterns (#15) Added pattern for * PackageIdentifier * PackageVersion * PackageFamilyName * PackageLocale * Readability (#16) * Add Comparison Functions for Readability * Simplify Validation Function * Fix: Missing text * Remove spaces from split function * Fix: Resolve renamed variable * Validate Installer Modes * Validate File Extensions with Pattern and Length * Add Custom Error Class (#18) * Create function for adding list parameters * Remove RAW writing * Remove Empty Manifest Folders * minItems, maxItems, pattern, variable fix * Implemented minItems from Schema * Implemented maxItems from Schema * Implemented pattern from Schema * Implemented available Architecture's from Schema * Implemented available InstallerType's from Schema * Added $script: to some variables which needs to stay throughout the script * Add Custom Error Class * Cleanup Class Constructor * Additional error messages + cleanup * Continue adding error messages * Switched Local formatter to OTBS + Static Strings (Where applicable) * Fix Spacing * Remove unused variables from rebase Co-authored-by: Esco <OfficialEsco@users.noreply.github.com> * Fix: Check for package before do-until * Finish Locale Errors * Fix Spacing Issues * Make Enums Case Sensitive * Fix Unique Items + Incorrect Variables Co-authored-by: Esco <OfficialEsco@users.noreply.github.com> * Subfolder fix (#21) * Fix: Subfolder Exists Erroring * Return * Write Unused Keys as Comments (#22) * Write Unused Keys as Comments * Exclude certain keys from appearing as comments * Comment only Locale + Version * Quick Update, Function Reduction, Detect Installer Types, Detect Installer Architectures, and Comments (#27) * Update YamlCreate.ps1 * auto-detect installer architecture * Fix #27 (comment) * Fix auto-detection * Apply suggestions from code review Co-authored-by: Kaleb Luedtke <trenlymc@gmail.com> * Move Test + Submit to main * Update Tools/YamlCreate.ps1 * fix quick-update check * Reduce input required for quick version update (#4) * Reduce input required for quick version update * Fix Product Code * Don't add null product code if no product code key exists * improve quick update * Move prompt outside of Read-Info for clarity * Move Update Prompt outside of Read-Info for clarity * Update Messages * if there are any errors due to this commit, i will revert changes * Add Comments for code clarity Co-authored-by: Kaleb Luedtke <trenlymc@gmail.com> * Fix error from when functions were moved * Handle Manifest Level Parameters (#34) * Begin Handling Manifest Level Parameters * Fix InstallModes * Add delete manifest functionality (#39) * Add functionality to manually delete manifests * Add settings file and script documentation (#38) * Do not default installer locale * Add a script settings file with documentation * Add setting to suppress quick update warning * Remove accidental file inclusion * Fix: Update SignatureSha256 in quick update mode (#41) * Change Settings to allow for negative suppression (#46) * Change Settings to allow for negative suppression * Fix sample settings file * Invalid SandboxTest variable Co-authored-by: Vedant Mohan Goyal <83997633+vedantmgoyal2009@users.noreply.github.com> Co-authored-by: Kaleb Luedtke <kaleb.carver.luedtke@jci.com> Co-authored-by: Esco <OfficialEsco@users.noreply.github.com> Co-authored-by: Vedant Mohan Goyal <83997633+vedantmgoyal2009@users.noreply.github.com> * Cleaner references to linked issues (#49) * Command Line Arguments (#50) * Add switch for settings * Allow PackageIdentifier and PackageVersion to be passed as optional parameters * Add -help switch and documentation * Settings File Location * Fix spacing issue [#49] #51 Co-authored-by: Kaleb Luedtke <kaleb.carver.luedtke@jci.com> Co-authored-by: Vedant Mohan Goyal <83997633+vedantmgoyal2009@users.noreply.github.com> * Fix Parameter Reading and Condensing(#54) * Fix: Allow InstallerSwitch keys to be split between installer level and manifest level on a per-key basis * Fix: Save parameters to variables before removing them from manifest level * Fix: Sandboxtest not working * Fix: Prompt for PFN if file does not exist (#55) * Auto Mode (#58) * Auto Mode * Fix for same version * Keep ProductCodes for .exe files * Keep ProductCodes for .exe files in Option-2 * Simplify function names, add debug info (#62) * Fix: Allow autoupdate to update old package versions (#66) * Make Simple Update automatically detect Sha256, SignatureSha256, and ProductCode without prompts (#61) * Make Simple Update automatically detect Sha256, SignatureSha256, and ProductCode without prompts * Add Parameter Mode (#64) * Add Parameter Mode * Update YamlCreate.ps1 * Update YamlCreate.md Co-authored-by: Vedant Mohan Goyal <83997633+vedantmgoyal2009@users.noreply.github.com> * Use Unique Branch Names (#67) * Use Unique Branch Names * Process Branch Names Safely * Fix: Allow values other than en-US for default locale (#70) * Made it so git config was only modified for the local repo. (#72) * Only modify git config for local repo. * Fixed 2214. * Support for settings on Linux and macOS (#73) * Support for settings on Linux and macOS * Easton's suggestion * Update YamlCreate.md * Update Tools/YamlCreate.ps1 Co-authored-by: Kaleb Luedtke <trenlymc@gmail.com> * Update YamlCreate.ps1 Co-authored-by: Kaleb Luedtke <trenlymc@gmail.com> * Check for open PR's before submitting (#69) * Check for open PR's before submitting * Rebase on c82b39f * Use API instead of CLI * Exit when user-choice to terminate Co-authored-by: Vedant Mohan Goyal <83997633+vedantmgoyal2009@users.noreply.github.com> Co-authored-by: Vedant Mohan Goyal <83997633+vedantmgoyal2009@users.noreply.github.com> * Throw when script error (#74) * Fix: Add locale when converting from singleton (#75) * Fix: Branch names when deleting (#79) * Fix: Don't check for PRs on deletion (#80) * Update PR Content when removing a manifest (#82) * Update PR Content when removing a manifest * More realistic character count limits * Add is:pr to exclude issues from results (#88) * Ensure file names are valid before saving (#85) * Ensure file names are valid before saving * Fix: Catch when content disposition doesn't exist * Fix UserAgent not following redirects * Additional Web Request Parameters * Fix: Min descriptor length + Agent * Fix: Escape Regex in variables (#91) * Fix: Only add moniker to defaultLocale (#92) * Chore: Add references to YamlCreate documentation (#93) * Typo (#94) * Chore: Add note to enable settings Co-authored-by: denelon <denelon@microsoft.com> * Chore: Remove To-do message * Update YamlCreate.ps1 * Move integer validation (#99) * Rename String.Validate -> Test-String (#101) * Suppress Write-Host warnings from ScriptAnalyzer * Fix missing constructor parameter * Rename Write-Locale-Manifests -> Write-LocaleManifest * Rename Write-Version-Manifest -> Write-VersionManifest * Rename Write-Installer-Manifest -> Write-InstallerManifest * Rename Read-WinGet-LocaleManifest -> Read-LocaleMetadata * Rename Read-WinGet-InstallerManifest -> Read-InstallerMetadata * Rename Read-Installer-Values-Minimal -> Read-QuickInstallerEntry * Rename Read-Installer-Values -> Read-InstallerEntry * Rename Enter-PR-Parameters -> Read-PRBody * Rename Write-Colors -> Write-MulticolorLine * Use Named Parameters for AddYamlParameter * Use Named Parameters for AddYamlListParameter * Use Named Parameters for PromptInstallerManifestValue * Support ShouldProcess for removing manifests * Move Downloading of installer to a separate function * More function name updates * Fix: Download Method (#107) * Check for version when setting proxy (#109) * Use defaultLocale due to microsoft/winget-cli#1646 resolving microsoft/winget-cli#1595 Co-authored-by: Esco <OfficialEsco@users.noreply.github.com> Co-authored-by: Vedant Mohan Goyal <83997633+vedantmgoyal2009@users.noreply.github.com> Co-authored-by: Levvie - she/her <11600822+ItzLevvie@users.noreply.github.com> Co-authored-by: Kaleb Luedtke <kaleb.carver.luedtke@jci.com> Co-authored-by: Easton Pillay <easton@planeteaston.com> Co-authored-by: denelon <denelon@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #30
@OfficialEsco I've begun handling and condensing parameters to and from the manifest level. I haven't tested this at all yet, but I'm 80% confident the main functionality is there if you'd like to help me find the bugs.
I still want to complete the rework to update the manifests in-place as part of this too, but I don't think that needs to be complete to test.