Check for open PR's before submitting #69

Trenly · 2021-10-04T17:28:32Z

cc @OfficialEsco @vedantmgoyal2009

vedantmgoyal9 · 2021-10-04T17:30:59Z

Thanks, @Trenly. 50% of vedantmgoyal9/vedantmgoyal9#18 is completed. Will be testing it just now.

vedantmgoyal9 · 2021-10-05T14:41:15Z

@Trenly What I think is that the logic is fine but it is problem with GitHub, I think it has problems because (on winget-pkgs repo especially), we are opening, closing, merging hundreds of PRs very frequently.

Rest, I would like to ask @jedieaston if he has some other method/suggestion(?)

Trenly · 2021-10-05T14:51:21Z

@Trenly What I think is that the logic is fine but it is problem with GitHub, I think it has problems because (on winget-pkgs repo especially), we are opening, closing, merging hundreds of PRs very frequently.

Rest, I would like to ask @jedieaston if he has some other method/suggestion(?)

What problems are you encountering?

Trenly · 2021-10-05T20:29:43Z

@vedantmgoyal2009 I’m not seeing any issues on my end. If you can describe what the issue is that you’re seeing I can try to look into it

vedantmgoyal9 · 2021-10-06T02:28:53Z

@Trenly Sorry for the late reply. The problem is that the filters listed by Easton do not work every time (at least for me).

Like in the below screenshot, I have a PR already opened for the path "manifests/s/SomePythonThings/ElevenClock/1.5" but CLI doesn't detect any PRs.

You can also refer to microsoft#29258 (comment)

Edit: If I am doing something wrong, please tell me.

Trenly · 2021-10-06T03:30:21Z

Interesting. It looks like the cli isn't finding them but the API is. I wonder what the difference is

Trenly · 2021-10-06T04:04:14Z

Try that @vedantmgoyal2009 . Keep in mind that no solution will be 100% accurate, but this should be more accurate than the CLI

cc @jedieaston

Trenly · 2021-10-06T11:56:36Z

@vedantmgoyal2009
I don’t think either are issues. If the PR has been merged in, then it still stands that the new package already exists in the repo. If the PR has been closed, there may be some issue that is preventing the version from being added, and the user should be allowed to determine whether to continue or not

The settings were combined to ContinueWithExistingPRs since the logic is no longer just for submitting

vedantmgoyal9

I feel using throw is a little messy. Can't we simply print and exit?

Tools/YamlCreate.ps1

vedantmgoyal9 · 2021-10-06T12:35:03Z

@vedantmgoyal2009 I don’t think either are issues. If the PR has been merged in, then it still stands that the new package already exists in the repo. If the PR has been closed, there may be some issue that is preventing the version from being added, and the user should be allowed to determine whether to continue or not

Yes, ~~I think~~ you are correct. I just realized that we are checking the beginning rather than at the end.

The settings were combined to ContinueWithExistingPRs since the logic is no longer just for submitting

Sorry, I didn't see that you have changed the YamlCreate.md in the commit cf7fcdc.

doc/tools/YamlCreate.md

Co-authored-by: Vedant Mohan Goyal <83997633+vedantmgoyal2009@users.noreply.github.com>

vedantmgoyal9

* Check for open PR's before submitting * Rebase on c82b39f * Use API instead of CLI * Exit when user-choice to terminate Co-authored-by: Vedant Mohan Goyal <83997633+vedantmgoyal2009@users.noreply.github.com> Co-authored-by: Vedant Mohan Goyal <83997633+vedantmgoyal2009@users.noreply.github.com>

* Install powershell-yaml * Enforce ordering of keys * Create function for adding list parameters * Write Version Manifest using Yaml Parser * Add To-Do Section * Rebase on master and cleanup commit history * Revert inadvertent changes from testing * Implement logic for installers using YAML parser * Fix statement in incorrect position * Remove RAW writing * Begin reading MultiManifests using Yaml parser * Cleanup unneeded variables * Bump Version * Read parameters from singletons * Add Product Code * Abstract ReadInstallerManifest to sub-function * Fix: Handle uninitialized variables * Merge New/Update, add EditMetadata * Fix: Change EditMetadata to work on singleton manifests * Fix: Update Git commit messages for accuracy * Remove Empty Manifest Folders * Fix: Correct text * Fix: Remove code for testing * Feature: If old manifests exist, update in place to preserve extra keys * Fix: Null Error when creating new * Fix: Cast only when installer code * Fix: Respect installer locale * Fix: Use UTF8 Encoding * Sort Yaml Keys * Git error handling * Fixed Moniker prompt for NewLocale * minItems, maxItems, pattern, variable fix * Implemented minItems from Schema * Implemented maxItems from Schema * Implemented pattern from Schema * Implemented available Architecture's from Schema * Implemented available InstallerType's from Schema * Added $script: to some variables which needs to stay throughout the script Only tested with one manifest as of now Cleanup If/Else logic & Rebase on master * Update method of getting Product Code from installer * SignatureSha256 and PackageFamilyName (#5) * More CommitTypes * Fill in PR Parameters microsoft#21940 (#4) * Detect PackageFamilyName for MSIX/APPX (#8) * Update YamlCreate.ps1 * Update YamlCreate.ps1 * Exclude .validation (#9) * Exclude .validation * Added exclude to ExistingVersions Co-authored-by: Levvie - she/her <11600822+ItzLevvie@users.noreply.github.com> * Add new line for PackageFamilyName (#10) * Standardize Keypress Menus (#11) * Standardize Keypress Menus * Fix: Use variable instead of pipeline * Fix Help Texts & Spacing * Cleanup Git Messages * Filter by Yaml * Remove debugging line Co-authored-by: Esco <OfficialEsco@users.noreply.github.com> Co-authored-by: Kaleb Luedtke <kaleb.carver.luedtke@jci.com> Co-authored-by: Esco <OfficialEsco@users.noreply.github.com> * Replaced PrBodyContentReply `n with array (#12) * Menu reduction (#13) * Simplify Code + Make Issues Entry Safer * Check issue validity * Fix unintended Revert Co-authored-by: Esco <OfficialEsco@users.noreply.github.com> * Fix unintended Revert Co-authored-by: Esco <OfficialEsco@users.noreply.github.com> * Fix unintended Revert Co-authored-by: Esco <OfficialEsco@users.noreply.github.com> Co-authored-by: Esco <OfficialEsco@users.noreply.github.com> * More patterns (#15) Added pattern for * PackageIdentifier * PackageVersion * PackageFamilyName * PackageLocale * Readability (#16) * Add Comparison Functions for Readability * Simplify Validation Function * Fix: Missing text * Remove spaces from split function * Fix: Resolve renamed variable * Validate Installer Modes * Validate File Extensions with Pattern and Length * Add Custom Error Class (#18) * Create function for adding list parameters * Remove RAW writing * Remove Empty Manifest Folders * minItems, maxItems, pattern, variable fix * Implemented minItems from Schema * Implemented maxItems from Schema * Implemented pattern from Schema * Implemented available Architecture's from Schema * Implemented available InstallerType's from Schema * Added $script: to some variables which needs to stay throughout the script * Add Custom Error Class * Cleanup Class Constructor * Additional error messages + cleanup * Continue adding error messages * Switched Local formatter to OTBS + Static Strings (Where applicable) * Fix Spacing * Remove unused variables from rebase Co-authored-by: Esco <OfficialEsco@users.noreply.github.com> * Fix: Check for package before do-until * Finish Locale Errors * Fix Spacing Issues * Make Enums Case Sensitive * Fix Unique Items + Incorrect Variables Co-authored-by: Esco <OfficialEsco@users.noreply.github.com> * Subfolder fix (#21) * Fix: Subfolder Exists Erroring * Return * Write Unused Keys as Comments (#22) * Write Unused Keys as Comments * Exclude certain keys from appearing as comments * Comment only Locale + Version * Quick Update, Function Reduction, Detect Installer Types, Detect Installer Architectures, and Comments (#27) * Update YamlCreate.ps1 * auto-detect installer architecture * Fix #27 (comment) * Fix auto-detection * Apply suggestions from code review Co-authored-by: Kaleb Luedtke <trenlymc@gmail.com> * Move Test + Submit to main * Update Tools/YamlCreate.ps1 * fix quick-update check * Reduce input required for quick version update (#4) * Reduce input required for quick version update * Fix Product Code * Don't add null product code if no product code key exists * improve quick update * Move prompt outside of Read-Info for clarity * Move Update Prompt outside of Read-Info for clarity * Update Messages * if there are any errors due to this commit, i will revert changes * Add Comments for code clarity Co-authored-by: Kaleb Luedtke <trenlymc@gmail.com> * Fix error from when functions were moved * Handle Manifest Level Parameters (#34) * Begin Handling Manifest Level Parameters * Fix InstallModes * Add delete manifest functionality (#39) * Add functionality to manually delete manifests * Add settings file and script documentation (#38) * Do not default installer locale * Add a script settings file with documentation * Add setting to suppress quick update warning * Remove accidental file inclusion * Fix: Update SignatureSha256 in quick update mode (#41) * Change Settings to allow for negative suppression (#46) * Change Settings to allow for negative suppression * Fix sample settings file * Invalid SandboxTest variable Co-authored-by: Vedant Mohan Goyal <83997633+vedantmgoyal2009@users.noreply.github.com> Co-authored-by: Kaleb Luedtke <kaleb.carver.luedtke@jci.com> Co-authored-by: Esco <OfficialEsco@users.noreply.github.com> Co-authored-by: Vedant Mohan Goyal <83997633+vedantmgoyal2009@users.noreply.github.com> * Cleaner references to linked issues (#49) * Command Line Arguments (#50) * Add switch for settings * Allow PackageIdentifier and PackageVersion to be passed as optional parameters * Add -help switch and documentation * Settings File Location * Fix spacing issue [#49] #51 Co-authored-by: Kaleb Luedtke <kaleb.carver.luedtke@jci.com> Co-authored-by: Vedant Mohan Goyal <83997633+vedantmgoyal2009@users.noreply.github.com> * Fix Parameter Reading and Condensing(#54) * Fix: Allow InstallerSwitch keys to be split between installer level and manifest level on a per-key basis * Fix: Save parameters to variables before removing them from manifest level * Fix: Sandboxtest not working * Fix: Prompt for PFN if file does not exist (#55) * Auto Mode (#58) * Auto Mode * Fix for same version * Keep ProductCodes for .exe files * Keep ProductCodes for .exe files in Option-2 * Simplify function names, add debug info (#62) * Fix: Allow autoupdate to update old package versions (#66) * Make Simple Update automatically detect Sha256, SignatureSha256, and ProductCode without prompts (#61) * Make Simple Update automatically detect Sha256, SignatureSha256, and ProductCode without prompts * Add Parameter Mode (#64) * Add Parameter Mode * Update YamlCreate.ps1 * Update YamlCreate.md Co-authored-by: Vedant Mohan Goyal <83997633+vedantmgoyal2009@users.noreply.github.com> * Use Unique Branch Names (#67) * Use Unique Branch Names * Process Branch Names Safely * Fix: Allow values other than en-US for default locale (#70) * Made it so git config was only modified for the local repo. (#72) * Only modify git config for local repo. * Fixed 2214. * Support for settings on Linux and macOS (#73) * Support for settings on Linux and macOS * Easton's suggestion * Update YamlCreate.md * Update Tools/YamlCreate.ps1 Co-authored-by: Kaleb Luedtke <trenlymc@gmail.com> * Update YamlCreate.ps1 Co-authored-by: Kaleb Luedtke <trenlymc@gmail.com> * Check for open PR's before submitting (#69) * Check for open PR's before submitting * Rebase on c82b39f * Use API instead of CLI * Exit when user-choice to terminate Co-authored-by: Vedant Mohan Goyal <83997633+vedantmgoyal2009@users.noreply.github.com> Co-authored-by: Vedant Mohan Goyal <83997633+vedantmgoyal2009@users.noreply.github.com> * Throw when script error (#74) * Fix: Add locale when converting from singleton (#75) * Fix: Branch names when deleting (#79) * Fix: Don't check for PRs on deletion (#80) * Update PR Content when removing a manifest (#82) * Update PR Content when removing a manifest * More realistic character count limits * Add is:pr to exclude issues from results (#88) * Ensure file names are valid before saving (#85) * Ensure file names are valid before saving * Fix: Catch when content disposition doesn't exist * Fix UserAgent not following redirects * Additional Web Request Parameters * Fix: Min descriptor length + Agent * Fix: Escape Regex in variables (#91) * Fix: Only add moniker to defaultLocale (#92) * Chore: Add references to YamlCreate documentation (#93) * Typo (#94) * Chore: Add note to enable settings Co-authored-by: denelon <denelon@microsoft.com> * Chore: Remove To-do message * Update YamlCreate.ps1 * Move integer validation (#99) * Rename String.Validate -> Test-String (#101) * Suppress Write-Host warnings from ScriptAnalyzer * Fix missing constructor parameter * Rename Write-Locale-Manifests -> Write-LocaleManifest * Rename Write-Version-Manifest -> Write-VersionManifest * Rename Write-Installer-Manifest -> Write-InstallerManifest * Rename Read-WinGet-LocaleManifest -> Read-LocaleMetadata * Rename Read-WinGet-InstallerManifest -> Read-InstallerMetadata * Rename Read-Installer-Values-Minimal -> Read-QuickInstallerEntry * Rename Read-Installer-Values -> Read-InstallerEntry * Rename Enter-PR-Parameters -> Read-PRBody * Rename Write-Colors -> Write-MulticolorLine * Use Named Parameters for AddYamlParameter * Use Named Parameters for AddYamlListParameter * Use Named Parameters for PromptInstallerManifestValue * Support ShouldProcess for removing manifests * Move Downloading of installer to a separate function * More function name updates * Fix: Download Method (#107) * Check for version when setting proxy (#109) * Use defaultLocale due to microsoft/winget-cli#1646 resolving microsoft/winget-cli#1595 Co-authored-by: Esco <OfficialEsco@users.noreply.github.com> Co-authored-by: Vedant Mohan Goyal <83997633+vedantmgoyal2009@users.noreply.github.com> Co-authored-by: Levvie - she/her <11600822+ItzLevvie@users.noreply.github.com> Co-authored-by: Kaleb Luedtke <kaleb.carver.luedtke@jci.com> Co-authored-by: Easton Pillay <easton@planeteaston.com> Co-authored-by: denelon <denelon@microsoft.com>

Trenly requested a review from OfficialEsco October 4, 2021 17:28

vedantmgoyal9 mentioned this pull request Oct 4, 2021

Some new things to be implemented [New Feature] vedantmgoyal9/vedantmgoyal9#18

Closed

Trenly force-pushed the CheckPRs branch from 69fb28d to a161d33 Compare October 5, 2021 04:00

This comment has been minimized.

Sign in to view

vedantmgoyal9 suggested changes Oct 6, 2021

View reviewed changes

Tools/YamlCreate.ps1 Outdated Show resolved Hide resolved

vedantmgoyal9 suggested changes Oct 6, 2021

View reviewed changes

doc/tools/YamlCreate.md Outdated Show resolved Hide resolved

Trenly force-pushed the CheckPRs branch from 46b96da to 09189a4 Compare October 6, 2021 14:18

Trenly and others added 4 commits October 6, 2021 09:29

Check for open PR's before submitting

93b3b0d

Rebase on c82b39f

33d0ab4

Use API instead of CLI

47fa946

Exit when user-choice to terminate

76d586b

Co-authored-by: Vedant Mohan Goyal <83997633+vedantmgoyal2009@users.noreply.github.com>

Trenly force-pushed the CheckPRs branch from 09189a4 to 76d586b Compare October 6, 2021 14:30

vedantmgoyal9 approved these changes Oct 6, 2021

View reviewed changes

Trenly merged commit 5f2f2f8 into YamlParsing Oct 6, 2021

Trenly deleted the CheckPRs branch October 6, 2021 14:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Check for open PR's before submitting #69

Check for open PR's before submitting #69

Trenly commented Oct 4, 2021

vedantmgoyal9 commented Oct 4, 2021 •

edited

Loading

vedantmgoyal9 commented Oct 5, 2021 •

edited

Loading

Trenly commented Oct 5, 2021

Trenly commented Oct 5, 2021

vedantmgoyal9 commented Oct 6, 2021 •

edited

Loading

Trenly commented Oct 6, 2021

Trenly commented Oct 6, 2021 •

edited

Loading

This comment has been minimized.

Trenly commented Oct 6, 2021 •

edited

Loading

vedantmgoyal9 left a comment •

edited

Loading

vedantmgoyal9 commented Oct 6, 2021 •

edited

Loading

vedantmgoyal9 left a comment

Check for open PR's before submitting #69

Check for open PR's before submitting #69

Conversation

Trenly commented Oct 4, 2021

vedantmgoyal9 commented Oct 4, 2021 • edited Loading

vedantmgoyal9 commented Oct 5, 2021 • edited Loading

Trenly commented Oct 5, 2021

Trenly commented Oct 5, 2021

vedantmgoyal9 commented Oct 6, 2021 • edited Loading

Trenly commented Oct 6, 2021

Trenly commented Oct 6, 2021 • edited Loading

This comment has been minimized.

Trenly commented Oct 6, 2021 • edited Loading

vedantmgoyal9 left a comment • edited Loading

Choose a reason for hiding this comment

vedantmgoyal9 commented Oct 6, 2021 • edited Loading

vedantmgoyal9 left a comment

Choose a reason for hiding this comment

vedantmgoyal9 commented Oct 4, 2021 •

edited

Loading

vedantmgoyal9 commented Oct 5, 2021 •

edited

Loading

vedantmgoyal9 commented Oct 6, 2021 •

edited

Loading

Trenly commented Oct 6, 2021 •

edited

Loading

Trenly commented Oct 6, 2021 •

edited

Loading

vedantmgoyal9 left a comment •

edited

Loading

vedantmgoyal9 commented Oct 6, 2021 •

edited

Loading