-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove TweakPane, use Leches #308
refactor: remove TweakPane, use Leches #308
Conversation
Run & review this pull request in StackBlitz Codeflow. |
✅ Deploy Preview for cientos-tresjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @andretchen0 thanks for the PR, two questions:
|
Converted to a draft. If you'd like me to split the PR by file, let me know. No problem either way. Fwiw, I'm almost done with
For functionality, I think it's generally equivalent. What you can do in one, you can largely do in the other. For improving Leches further, these things come to mind. Compact viewFor the same controls, Tweakpane is roughly half the height of Leches. I often find myself tweaking/removing controls to get Leches to fit in a window. That's a design tradeoff, but since I'm mostly working on docs/playground examples aimed at other devs, I'd trade whitespace/larger controls/larger type for having more controls "above the fold". Embeddable in a pageFor the Cientos docs examples, it'd be great if we could embed the controls above/below the inline THREE window. I often find myself removing controls I'd like to show off because there's just not enough space in the little inline demo window for another Leches widget. Folder APII often have to consult the source/tests to figure out how to add folders – i.e., useControls("folder name", controls). Afaik, for multiple folders, you have to make multiple calls to
Maybe using the usual API and adding a
|
@andretchen0 I can't thank you enough for the detailed feedback, I will work on improving tres leches based on what you provided me |
Following the conversation at #183, I've removed all Tweakpane references from the docs site. Just fyi ... Miscellaneous removed references to TweakpaneAside from imports of
Leches version bump in playgroundIn the playground/CameraControlsDemo there were buttons in the Tweakpane UI. Leches has buttons as of v0.14, but cientos was using v0.13. I bumped the Leches version only in playground/package.json. I didn't bump the Leches version anywhere else. |
Hi @andretchen0 I think we should keep the docs pages but with a warning that has been deprecated since version X and adds a link to v-tweakpane as an option for users, wdyt? |
Ok, I've reverted the deletion of the useTweakpane docs page and added the link back to the docs sidebar nav.
Sure, I added a "deprecated" badge. On the docs site and in the module itself, there's been a "soon to be deprecated" warning for a while. I said it was deprecated "as of v3.7.0" – the current version of Cientos. Is that ok?
Sure thing. Suggestions to migrate to Leches or v-tweakpane have been up for a while. I left those in place. |
…ls-to-tresjsleches
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incredible amount of work, thanks a lot @andretchen0 🙏🏻
Removes TweakPane in demos. Uses Leches instead.
Related #183