feat: rounded box #348
feat: rounded box #348
Conversation
|
|
|
Hi @JaimeTorrealba this is planned for v4 or would be better to have it available on an ealier version? |
|
I would say not for the v4. @alvarosabu |
There was a problem hiding this comment.
Hey @JaimeTorrealba ,
Looks good! Just some minor changes/cleanup.
docs/guide/shapes/rounded-box.md
Outdated
| @@ -0,0 +1,30 @@ | |||
| # Rounded-box <Badge type="warning" text="^3.8.1" /> | |||
There was a problem hiding this comment.
Probably best to use the component name as the page title:
# RoundedBox <Badge type="warning" text="^3.8.1" />
docs/guide/shapes/rounded-box.md
Outdated
| @@ -0,0 +1,30 @@ | |||
| # Rounded-box | |||
There was a problem hiding this comment.
(Non-blocking)
(I see that the badge was removed, but "Rounded-box" wasn't changed. I'm not sure if that was intentional.)
My preference would be to change this to ...
# RoundedBox
... since that's the name of the component. But there are some kebab-case names in the docs site, so I won't hold up the PR.
There was a problem hiding this comment.
Nop you're right, I'll fix this.
No description provided.