chore: fix linter errors #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@andretchen0 Yes, the lint had changed and my code was no longer correct. Sorry about that! Everything seems OK with your changes. 👌 |
damienmontastier
approved these changes
May 2, 2024
JaimeTorrealba
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Cientos'
mainis failing the CI linter step.The
<PositionalAudio />component got committed tomain. It has linter errors according to the recently updated eslint rules.Since the linter errors have been merged into
main, branches based onmainalso can't pass the local linter and fail the CI linter.Solution
Fixed the linter errors in
<PositionalAudio />.Context
@damienmontastier , first: no worries. I imagine this is just a case of PR making it into
mainaround the time the linter rules were updated.Second: I've verified that the component works to the best of my knowledge, but please have a look. The linter was unable to automatically fix a number of reported errors, so I had to make a number of changes by hand.
Third: feel free to ignore here and open a fresh PR with your fixes.
I usually don't like to edit others' components, but since this is blocking all other PRs, I wanted to speed up an eventual fix.