(v4) Tests without root fail

[andretchen0]

Describe the bug

Description

I'm trying to write some simple vitest tests for nodeOps. Here's an example:

  it ('should not throw on nodeOps.remove', async() => {
    const mesh = nodeOps.createElement('TresMesh')
    const parent = nodeOps.createElement('TresMesh')
    nodeOps.insert(mesh, parent)
    nodeOps.remove(mesh)
  })

This test fails with the following error:

TypeError: deregisterBlockingObjectAtPointerEventHandler is not a function

Desired outcome

Insertions/removals without a root shouldn't throw.

Steps to reproduce

• Insert example into src/core/nodeOps.test.ts
• pnpm run test:ui
• See failing test

Context

Related: #515

The code that throws starts at line 137:

    const ctx = node.__tres
    // remove is only called on the node being removed and not on child nodes.
    node.parent = node.parent || scene
    
    const { 
      deregisterObjectAtPointerEventHandler,
      deregisterBlockingObjectAtPointerEventHandler, 
    } = ctx.root

Proposed solution

Dispatch an event and handle at the root. That would allow the tests to pass and reduce some coupling at the same time.

For what it's worth, this is how THREE.Material.dispose() works, which is called in the Tres code right below the block shown above.

Used Package Manager

pnpm

Code of Conduct

• I agree to follow this project's Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• The provided reproduction is a minimal reproducible example of the bug.

[alvarosabu]

Hi @andretchen0 I think @garrlker PR #529 will remove the need to use those methods. But, for tests we will need to mock the root state since its widely used

[andretchen0]

@alvarosabu Ok. I'll close the issue here.