Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Team to 2.4 #34

Merged
merged 1 commit into from
Sep 2, 2014
Merged

Updated Team to 2.4 #34

merged 1 commit into from
Sep 2, 2014

Conversation

mattcan
Copy link
Contributor

@mattcan mattcan commented Sep 1, 2014

The latest version of the Team API allows a client
to request up to 10 summoners at a time. There is also the ability
to search for a team based on their TeamID or up to 10 Teams.

I've also added a function to create comma seperated strings
based on TeamIDs. This is very similar to createSummonerIDString
except that it takes a []string as an argument versus a []int64.

A test has been added for TeamByTeamID.

The latest version of the Team API allows a client
to request up to 10 summoners at a time. There is also the ability
to search for a team based on their TeamID or up to 10 Teams.

I've also added a function to create comma seperated strings
based on TeamIDs. This is very similar to `createSummonerIDString`
except that it takes a `[]string` as an argument versus a `[]int64`.

A test has been added for `TeamByTeamID`.
TrevorSStone added a commit that referenced this pull request Sep 2, 2014
@TrevorSStone TrevorSStone merged commit 5b65b47 into TrevorSStone:master Sep 2, 2014
@TrevorSStone
Copy link
Owner

I appreciate you doing these. Good job. A minor thing is that you end up double checking the max length of the input teamIDs because you check it both inside and outside of createSummonerIDString. It's really not a huge deal but I figured I would point it out. Otherwise everything looks good to me.

Have you made any cool projects with the library yet? Would love to see them

@mattcan
Copy link
Contributor Author

mattcan commented Sep 3, 2014

Thanks, I'm happy to help out!

For the createSummonerIDString method, I decided to do the double check because I wasn't quite prepared to making a change across a few files. Since the Team API only allows 10 summoners but Summoners and League (I think) allow 40 summoner lookups, do you think that we should move all the checks to be outside of createSummonerIDString or change the method interface to be something like

func createSummonerIDString( summonerID []int64, summonerLimit int ) (summonerIDstr string, err error) {}

Doing that keeps the check internal but also makes clear how many are allowed.


With the new Match API becoming available, I'm revitalizing a project I started a few months ago called Coach Of Legends. It is meant to provide analysis for players based on how they play and how others at their level or higher play. Hopefully I'll finish one day.. haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants