Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature RQ] Documentation for adding github and google login auths #32

Closed
1 task done
TreyWW opened this issue Aug 19, 2023 · 6 comments · Fixed by #79
Closed
1 task done

[Feature RQ] Documentation for adding github and google login auths #32

TreyWW opened this issue Aug 19, 2023 · 6 comments · Fixed by #79
Assignees
Labels

Comments

@TreyWW
Copy link
Owner

TreyWW commented Aug 19, 2023

Need to add some documentation somewhere to show users how to add goole and github oauths

References for how you can add it
Github
Google

Pretty much just need to do this to add them:

  • Add your env variables
GITHUB_KEY=
GITHUB_SECRET=

GOOGLE_CLIENT_ID=
GOOGLE_CLIENT_SECRET=
GOOGLE_CLIENT_URI=

Here's a video which you can watch to add on github and here's a video you can watch to add on google
use #32 (comment) to create on github and google

I pretty much need you to just

  • Add a documentation page somewhere that outlines the steps (no videos). Thanks
@TreyWW
Copy link
Owner Author

TreyWW commented Aug 19, 2023

As for the videos / adding on google on github actual oauth settings here's a better idea:

Github

Then, generate a new client secret, and put that in your ENV GITHUB_SECRET. Also put your CLIENT ID as GITHUB_KEY

Google

@TreyWW
Copy link
Owner Author

TreyWW commented Oct 4, 2023

Please leave a comment if you would like to work on this and you will be assigned. I appreciate any help

@romana-la
Copy link
Contributor

Hi @TreyWW, I would like to work on this issue.

@TreyWW
Copy link
Owner Author

TreyWW commented Oct 5, 2023

Hi there @romana-la,

Of course, thank you for showing interest in the project. I've just assigned you, make a pull request when you're done, or ask for help here :)

Really appreciate it

@romana-la
Copy link
Contributor

Thanks :) I have made a new pull request, please feel free to suggest any changes if necessary. For Authorized redirect URI in Google, I tested it with http://127.0.0.1:8000/login/external/complete/google-oauth2/ and it worked.

@TreyWW
Copy link
Owner Author

TreyWW commented Oct 8, 2023

Great! Thank you for testing it too. In the future we may want a guide for production aswell as local host, but to be fair it should be self explanatory for people. So I really do appreciate your contribution.

I hope you enjoyed viewing our project, if you'd like to work on anything else, know how to work anything or anything similar just let me know. I appreciate it 😄

@TreyWW TreyWW closed this as completed in #79 Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants