Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#72 | Bug: Add cp step for github action docker file / compose #144

Merged
merged 9 commits into from
Dec 6, 2023

Conversation

HessTaha
Copy link
Contributor

@HessTaha HessTaha commented Dec 4, 2023


#72 | Bug: Add cp step for github action docker file / compose

Checklist

  • Ran the Black Formatter on any new code (checks will fail without)
  • Made any changes or additions to the documentation where required
  • Changes generate no new warnings/errors
  • New and existing unit tests pass locally with my changes

What type of PR is this?

  • 🐛 Bug Fix
  • ♻️ Code Refactor

Description

  • 310dae7 > Moved docker-compose.ci.yaml file to infrastructure/backend
  • 742873a ~> Added a copy step to unit test workflow
  • 72f7577 ~> Grouped install instructions for better readability inside the Dockerfile also under infrastructure/backend

Added/updated tests?

  • 🙅 no, because they aren't needed

Related PRs, Issues etc

@HessTaha HessTaha changed the title Bug: Add cp step for github action docker file / compose #72 | Bug: Add cp step for github action docker file / compose Dec 4, 2023
@TreyWW TreyWW merged commit 9c341a7 into TreyWW:main Dec 6, 2023
3 checks passed
@TreyWW
Copy link
Owner

TreyWW commented Dec 6, 2023

Thank you so much for your contribution @HessTaha! I was trying to figure that out for a while so it's amazing that you managed to do it. Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants