Fix package test/example enable logic for global test/example case (#trilinos/Trilinos#11002) #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vars (TriBITSPub#63) The macro and the vars were pooly named for what they actually do. This should make it easier to fix the bug in trilinos/Trilinos#11002.
…rilinos/Trilinos#11002) Added new macro tribits_set_package_enable_based_on_global_enable_on() to fix the use case described in trilinos/Trilinos#11002 and demonstrated by the new dependency test case: * TriBITS_DepTests_EnableThyra_EnableExamples_EnableTestsEmpty_DisableThyraExamples_EnableThyraTests that was failing and now passes. I tweaked the pass regex to catch the new output but the behavior.
rabartlett1972
approved these changes
Oct 4, 2022
|
@KyleFromKitware, can you please do a post-merge review of this PR? |
This was referenced Oct 4, 2022
Merged
|
+1 |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a failing test to show the defect reported in #trilinos/Trilinos#11002 and then updates the code to make the test pass.
I think this TriBITS enable/disable logic could use a little more messaging but I think this is okay for now.