Remove unused/unneeded list vars and logic for packages and TPLs (#299, #63) #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, I could not remove the computation of the full set of direct and indirect dependencies for each pacakge <Package>_FULL_ENABLED_DEP_PACKAGES because the function tribits_find_most_recent_file_timestamp() still needs this. The only customer that still needs that function is CASL VERA (to compute when it is needed to rebuild MOOSE). Therefore, for now, I can't remove this code (which is more complex and can be an expensive computation if there are a **lot** of packages).
#63) This commit gets rid of several list variables that are not needed with the move to modern CMake and some fairly complex code that was needed to compute these list variables: * <Project>_REVERSE_DEFINED_INTERNAL_PACKAGES * <Project>_REVERSE_DEFINED_TPLS * <Project>_TPL_LIST * <Package>_PACKAGE_LIST * <Package>_TPL_LIST * <Package>_INCLUDE_DIR * <Package>_LIBRARY_DIRS * <Package>_TPL_INCLUDE_DIRS * <Package>_TPL_LIBRARIES * <Package>_TPL_LIBRARY_DIRS Some of these changes impact only internal code but some impact even customers of the installed <Project>Config.cmake and <Package>Config.cmake files (see the new entries in tribits/CHANGELOG.md). This required some minor updates to the example projects: * tribits/examples/TribitsExampleApp/ * tribits/examples/TribitsOldSimpleExampleApp/ * tribits/examples/TribitsSimpleExampleApp/ for some logic that used <Project>_TPL_LIST. (There is no need to use that with updated TriBITS. See the diffs in this commit for those projects to see how they were adjusted.)
|
Hello @KyleFromKitware, can you please give this PR a review when you get some time? I will build my next branch off of this branch to continue work in the meantime. |
KyleFromKitware
requested changes
Oct 17, 2022
tribits/core/package_arch/TribitsSetUpEnabledOnlyDependencies.cmake
Outdated
Show resolved
Hide resolved
tribits/core/package_arch/TribitsSetUpEnabledOnlyDependencies.cmake
Outdated
Show resolved
Hide resolved
tribits/core/package_arch/TribitsSetUpEnabledOnlyDependencies.cmake
Outdated
Show resolved
Hide resolved
tribits/core/package_arch/TribitsSetUpEnabledOnlyDependencies.cmake
Outdated
Show resolved
Hide resolved
tribits/core/package_arch/TribitsSetUpEnabledOnlyDependencies.cmake
Outdated
Show resolved
Hide resolved
tribits/core/package_arch/TribitsSetUpEnabledOnlyDependencies.cmake
Outdated
Show resolved
Hide resolved
Addresses review commits from PR #531.
|
Hello @KyleFromKitware, all of the issues you raised in your review above should be addressed in the new commit |
KyleFromKitware
approved these changes
Oct 18, 2022
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a cleanup PR to allow the next step in working towards #63 (and removing some stuff not needed after the completion of #299).
See the individual commit messages for what was changed and why.
Instructions for Reviewers