Update some build ref docs for TriBITS upgrade (#63, #299) #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| -D <Project>_ENABLE_<TRIBITS_PACKAGE><A>=OFF \ | ||
| -D <Project>_ENABLE_<TRIBITS_PACKAGE><B>=OFF \ | ||
| ... | ||
|
|
||
| The disable of the subpackage is this case will override any enables. | ||
| The disable of the subpackages is this case will override any enables. |
KyleFromKitware
previously requested changes
Nov 7, 2022
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this pull request
Nov 7, 2022
…SPub#299) I noticed some of these issue while reading the documentation online.
bartlettroscoe
force-pushed
the
63-improve-build-ref-doc-1
branch
from
c8baffe
to
c1cfad5
Compare
rabartlett1972
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
As @KyleFromKitware had just one requested change, and that was addressed in a follow-up commit, I will go ahead and approve so this can merge.
bartlettroscoe
dismissed
KyleFromKitware’s stale review
The one typo flagged was fixed
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some of these issue while reading the documentation online.