TribitsAdjustPackageEnables.cmake: Use clean code ordering and more cleanup (#63) #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlettroscoe
changed the title
Base automatically changed from
63-combined-package-data-structures-4
to
master
December 12, 2022 18:53
rabartlett1972
previously approved these changes
Dec 12, 2022
bartlettroscoe
force-pushed
the
63-combined-package-data-structures-5
branch
from
7e0a636
to
094956d
Compare
Just saw this while working on #63 refactorings.
This ordering makes more sense compared to the reverse clean code ordering that I usesd to use. In CMake, you can call macros/functions defined after the call in the source file (and this is true of most languages, even static langauges like C++ due to forward declarations).
* Rename local vars to camelCase and pick better names for some vars * Remove unused vars
bartlettroscoe
force-pushed
the
63-combined-package-data-structures-5
branch
from
094956d
to
b616ad3
Compare
KyleFromKitware
approved these changes
Dec 12, 2022
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now this module
TribitsAdjustPackageEnables.cmakeshould be ready for the next set of refactorings and extensions to complete #63.Instructions for reviewers
Best to review this PR commit-by-commit:
63-combined-package-data-structures-4from PR Repalce usage of legacy vars <Package>_[LIB|TEST]_[REQUIRED|OPTIONAL]_DEP_[PACKAGES|TPLS] (#63) #546 and that is the target branch for this PR (because PR Repalce usage of legacy vars <Package>_[LIB|TEST]_[REQUIRED|OPTIONAL]_DEP_[PACKAGES|TPLS] (#63) #546 has not merged to 'master' yet).