Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query-typegoose): update peer dependencies #116

Merged
merged 4 commits into from
Apr 5, 2023

Conversation

smolinari
Copy link
Contributor

Hi,

Not sure I did this right as I'm not experienced with Nx. Ran tests though and they all passed.

I need this package updated to the newest versions of my @m8a/nestjs-typegoose, @typegoose/typegoose and @mongoose packages.

Please do let me know if something is wrong.

How fast can you publish a new version?

Scott

@TriPSs
Copy link
Owner

TriPSs commented Mar 31, 2023

Thanks for the PR! I think the tests/linting needs to be update to support mongoose 7

@smolinari
Copy link
Contributor Author

Interesting. I assumed testing did building too. Now I see the issues when building. LOL! I'm on it. Just not sure my TypeScript-fu is good enough to figure this out. We'll see.

Scott

@smolinari
Copy link
Contributor Author

I believe this also means, this would need to be a major bump in version too, right? 🤔

Scott

@TriPSs
Copy link
Owner

TriPSs commented Mar 31, 2023

Uhmm, if it stays compatible with the old version then no otherwise yes :)

@smolinari
Copy link
Contributor Author

@TriPSs - I hope it's good to go now. 😁

Scott

@smolinari
Copy link
Contributor Author

@TriPSs - Sorry to be pushy, but is this ok and can you get the package updated?

Scott

@TriPSs
Copy link
Owner

TriPSs commented Apr 5, 2023

@TriPSs - Sorry to be pushy, but is this ok and can you get the package updated?

Scott

Could you check the last tests that are failing?

@smolinari
Copy link
Contributor Author

smolinari commented Apr 5, 2023

@TriPSs - Those errors seem to be issues with the Mongoose package. Should I update it too?

Scott

@smolinari
Copy link
Contributor Author

It's actually a mix of errors. The init script path for mongo is also broken. Had to fix it to run docker compose.

I can look into the mongoose issues. But the other two are a bit out of my comfort zone.

[Nest] 190142  - 04/05/2023, 1:14:10 PM   ERROR [ExceptionsHandler] No AuthorizationContext available for method failingTodoItems! Make sure that you provide an AuthorizationContext to your custom methods as argument of the @AuthorizerFilter decorator.
Error: No AuthorizationContext available for method failingTodoItems! Make sure that you provide an AuthorizationContext to your custom methods as argument of the @AuthorizerFilter decorator.
    at Object.get (/home/scott/Documents/tmp/nestjs-query-trips/packages/query-graphql/src/decorators/authorize-filter.decorator.ts:40:15)
    at Object.authorize (/home/scott/Documents/tmp/nestjs-query-trips/examples/auth/src/todo-item/dto/todo-item.dto.ts:23:28)
    at DefaultAuthorizer.authorize (/home/scott/Documents/tmp/nestjs-query-trips/packages/query-graphql/src/auth/default-crud.authorizer.ts:49:27)
    at getAuthorizerFilter (/home/scott/Documents/tmp/nestjs-query-trips/packages/query-graphql/src/decorators/authorize-filter.decorator.ts:19:29)
    at /home/scott/Documents/tmp/nestjs-query-trips/packages/query-graphql/src/decorators/authorize-filter.decorator.ts:59:7
    at /home/scott/Documents/tmp/nestjs-query-trips/node_modules/@nestjs/core/helpers/context-utils.js:40:28
    at resolveParamValue (/home/scott/Documents/tmp/nestjs-query-trips/node_modules/@nestjs/core/helpers/external-context-creator.js:138:31)
    at Array.map (<anonymous>)
    at pipesFn (/home/scott/Documents/tmp/nestjs-query-trips/node_modules/@nestjs/core/helpers/external-context-creator.js:141:45)
    at /home/scott/Documents/tmp/nestjs-query-trips/node_modules/@nestjs/core/helpers/external-context-creator.js:69:23
[Nest] 190142  - 04/05/2023, 1:14:11 PM   ERROR [ExceptionsHandler] Unable to find all subTasks to add to TodoItemEntity
Error: Unable to find all subTasks to add to TodoItemEntity
    at TypeOrmQueryService.addRelations (/home/scott/Documents/tmp/nestjs-query-trips/packages/query-typeorm/src/services/relation-query.service.ts:215:13)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async TodoItemAssembler.convertAsyncToDTO (/home/scott/Documents/tmp/nestjs-query-trips/packages/core/src/assemblers/abstract.assembler.ts:64:15)

and

[Nest] 190142  - 04/05/2023, 1:14:33 PM   ERROR [ExceptionsHandler] Unable to find todoItem to set on SubTaskEntity
Error: Unable to find todoItem to set on SubTaskEntity
    at TypeOrmQueryService.setRelation (/home/scott/Documents/tmp/nestjs-query-trips/packages/query-typeorm/src/services/relation-query.service.ts:266:13)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async DefaultAssembler.convertAsyncToDTO (/home/scott/Documents/tmp/nestjs-query-trips/packages/core/src/assemblers/abstract.assembler.ts:64:15)

Scott

@smolinari
Copy link
Contributor Author

smolinari commented Apr 5, 2023

Hmm... strange. All tests showing passing. Ok. Nevermind. 😁

Edit: I guess those exceptions are being tested for, since everything passed.

Scott

@smolinari
Copy link
Contributor Author

smolinari commented Apr 5, 2023

Why is codecov failing? That is beyond me as I only added a type. 🤷

Scott

@TriPSs
Copy link
Owner

TriPSs commented Apr 5, 2023

Thanks for the PR!

@TriPSs TriPSs merged commit 5ecef19 into TriPSs:master Apr 5, 2023
@smolinari
Copy link
Contributor Author

@TriPSs - Hey Tycho...any ETA on a release?

Scott

@TriPSs
Copy link
Owner

TriPSs commented Apr 11, 2023

This should be released in the latest version?

@smolinari
Copy link
Contributor Author

How the heck did I miss that? 🤦

Thanks!!!

Scott

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants