-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(query-typegoose): update peer dependencies #116
Conversation
Thanks for the PR! I think the tests/linting needs to be update to support mongoose 7 |
Interesting. I assumed testing did building too. Now I see the issues when building. LOL! I'm on it. Just not sure my TypeScript-fu is good enough to figure this out. We'll see. Scott |
I believe this also means, this would need to be a major bump in version too, right? 🤔 Scott |
Uhmm, if it stays compatible with the old version then no otherwise yes :) |
@TriPSs - I hope it's good to go now. 😁 Scott |
@TriPSs - Sorry to be pushy, but is this ok and can you get the package updated? Scott |
Could you check the last tests that are failing? |
@TriPSs - Those errors seem to be issues with the Mongoose package. Should I update it too? Scott |
It's actually a mix of errors. The init script path for mongo is also broken. Had to fix it to run docker compose. I can look into the mongoose issues. But the other two are a bit out of my comfort zone.
and
Scott |
Hmm... strange. All tests showing passing. Ok. Nevermind. 😁 Edit: I guess those exceptions are being tested for, since everything passed. Scott |
Why is codecov failing? That is beyond me as I only added a type. 🤷 Scott |
Thanks for the PR! |
@TriPSs - Hey Tycho...any ETA on a release? Scott |
This should be released in the latest version? |
How the heck did I miss that? 🤦 Thanks!!! Scott |
Hi,
Not sure I did this right as I'm not experienced with Nx. Ran tests though and they all passed.
I need this package updated to the newest versions of my
@m8a/nestjs-typegoose
,@typegoose/typegoose
and@mongoose
packages.Please do let me know if something is wrong.
How fast can you publish a new version?
Scott