fix: Apply filters from relations to query

[cbjjensen]

No description provided.

[cbjjensen]

This change allows us to pass filters to the relatinoships of the query.

Sample usage:

        query.relations[usersAssociationTable].query = {
          relations: [{
            name: 'user', query: {
              filter: {
                uuid: { eq: 'e405f151-bd78-4f61-b7e9-23ca4b89b6c2' }
              },
            }
          }]

        } as any

Output SQL

SELECT "Table"."id", "Table"."some_identifier"
FROM myTable "Table"
LEFT JOIN "public"."user" "user" ON "user"."id"="users_association"."user_id"   
LEFT JOIN "public"."users_association" "users_association" ON "users_association"."some_identifier"="Table"."some_identifier"   
WHERE ("user"."uuid" = $1);

 -- PARAMETERS: ["e405f151-bd78-4f61-b7e9-23ca4b89b6c2"]

Previously, the relations' filters would not be passed down, and would result in the below query instead:

SELECT "Table"."id", "Table"."some_identifier"
FROM myTable "Table"
LEFT JOIN "public"."user" "user" ON "user"."id"="users_association"."user_id"   
LEFT JOIN "public"."users_association" "users_association" ON "users_association"."some_identifier"="Table"."some_identifier";

It appears that Doug left a comment in the code indicating that this was a missing feature, so i've removed it, and addressed it by calling applyFilters from the applyRelationJoinsRecursive logic.

[TriPSs]

Shit, this is a good one. Thanks!

It's true that the filters where not applied, mainly also when implementing the lookahead this is something that could never be passed down by the query itself so there was no need yet to implement that.

[TriPSs]

Could you check the linting and please use conventional commits for the changelog.

There is also no need to bump the package.json :)

[TriPSs]

Is it me or don't I see this one back inside the snapshot?

[cbjjensen]

Hmm, it looks like you're right. I'll try to fix. Although it looks like some of the other where filters are not being built in the snapshots for even some of the other things unrelated to this change 😕

[cbjjensen]

comments have been addressed: 0ec70e2

[cbjjensen]

Could you check the linting and please use conventional commits for the changelog.

There is also no need to bump the package.json :)

I've no idea what i'm doing, in regards to commit history, haha. let me know if it needs to be cleaned up. Usually i'm the type of person that does test, test, oops, test, test, fixed a thing, so this styling is new to me!

[cbjjensen]

Should I move this to filter-query tests?

[TriPSs]

Yea let's do that.

[cbjjensen]

55fa165 addressed!

[TriPSs]

Thanks for your work on this already 🔥 !

[codecov-commenter]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3ceb52d) 79.15% compared to head (55fa165) 86.28%.
Report is 1 commits behind head on master.

Files	Patch %	Lines
...es/query-typeorm/src/query/filter-query.builder.ts	66.66%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
+ Coverage   79.15%   86.28%   +7.13%     
==========================================
  Files         688      688              
  Lines        9748     9750       +2     
  Branches      857      858       +1     
==========================================
+ Hits         7716     8413     +697     
+ Misses       1288      619     -669     
+ Partials      744      718      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cbjjensen]

@TriPSs this is ready for your approval. As a side question - once this is merged, will it auto increment the version in package json ? If not, when/how do i pull down the new version with the changes

[TriPSs]

@TriPSs this is ready for your approval. As a side question - once this is merged, will it auto increment the version in package json ? If not, when/how do i pull down the new version with the changes

The CI will bump versions and release it.