Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme rework #44

Merged
merged 52 commits into from
Aug 7, 2022
Merged

Readme rework #44

merged 52 commits into from
Aug 7, 2022

Conversation

Ilithy
Copy link
Collaborator

@Ilithy Ilithy commented Aug 6, 2022

  • I have placed your header, until modified (if you like what I will offer you as a replacement).

  • I haven't added dynamic badges yet (I like it a lot), they require additional files (build.yalm for example), I'm not very strong in code (if you want to make fun of it, fire ;-)), and I don't want to do stupid stupidity, so no indeed, there isn't any dynamics, not yet... ^_°

  • Old screenshots have been replaced in their specific folders.

  • the art/ folder has disappeared in the bermuda triangle.

  • I centered all this a little, for ease of readability (and especially to follow your comment)

  • I have totally hidden the links in text versions, but have left them, for the moment (to discuss)

@TrianguloY TrianguloY self-assigned this Aug 6, 2022
@TrianguloY TrianguloY added the enhancement New feature or request label Aug 6, 2022
@Ilithy
Copy link
Collaborator Author

Ilithy commented Aug 6, 2022

I have modified the header with a (different) proposal, feel free to be totally honest, I will change as much as necessary.

The image is under a free license, just requiring a simple attribution (as long as it is not printed and/or used for profit), if you checked this, here is the license file (be careful, the attribution requests of this file are for a physical print use): https://drive.proton.me/urls/QDS66G2NM0#Smeiaj9WowVw
Designer name: royyimzy25414
File link: https://www.vecteezy.com/vector-art/6826888-global-network-connection-world-map-point-and-line-composition-concept-of-global-business-vector-illustration

[Edit] Image size is 1024px by 500px And less than 500ko.

@TrianguloY
Copy link
Owner

I renamed the files to avoid duplicates (you can access them on the github log in any case). I also used relative links so that they get the files from the local branch.

@TrianguloY
Copy link
Owner

I added some 'dynamic' badges. They don't require any code at all! I also removed those with information that can be viewed from the main github page too.

@TrianguloY
Copy link
Owner

I have modified the header with a (different) proposal, feel free to be totally honest, I will change as much as necessary.

The image is under a free license, just requiring a simple attribution (as long as it is not printed and/or used for profit), if you checked this, here is the license file (be careful, the attribution requests of this file are for a physical print use): https://drive.proton.me/urls/QDS66G2NM0#Smeiaj9WowVw Designer name: royyimzy25414 File link: https://www.vecteezy.com/vector-art/6826888-global-network-connection-world-map-point-and-line-composition-concept-of-global-business-vector-illustration

[Edit] Image size is 1024px by 500px And less than 500ko.

Hmm, to be honest I prefer the previous background, although this one is nice too. The text/icon still blends with it though (sorry for being too repetitive). Maybe I can...

@TrianguloY
Copy link
Owner

What about this one?
featured

It's edited from a free domain one, so no attribution required: https://www.maxpixel.net/Digital-Network-Internet-Communication-Connections-3537400

@Ilithy
Copy link
Collaborator Author

Ilithy commented Aug 7, 2022

Yes is really great!
More readable than my versions, simple and elegant, I prefer it to the previous version (especially to my last one)

Sorry I didn't have the time today to test other designs

@TrianguloY
Copy link
Owner

I think this PR is now ready to merge, can still be improved in the future if needed.
If you agree, mark it as ready (remove the 'draft' property). If you still want to make more changes just keep it.

@Ilithy Ilithy marked this pull request as ready for review August 7, 2022 20:15
@Ilithy
Copy link
Collaborator Author

Ilithy commented Aug 7, 2022

I agree, as you say, it will be time later to make small changes, thanks.

@TrianguloY TrianguloY merged commit 897f010 into TrianguloY:master Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants