Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bartercast statistics community #1230

Merged
merged 7 commits into from
Feb 18, 2015
Merged

Bartercast statistics community #1230

merged 7 commits into from
Feb 18, 2015

Conversation

corpaul
Copy link

@corpaul corpaul commented Feb 17, 2015

Adds bartercast4 community and statistics for tunnel and torrent received stats. Also adds statistics database and debug panel for these stats. (works with dispersy/devel)

@tribler-ci
Copy link
Contributor

Merged build triggered.

@tribler-ci
Copy link
Contributor

Merged build started.

@tribler-ci
Copy link
Contributor

Merged build triggered.

@tribler-ci
Copy link
Contributor

Merged build started.

@tribler-ci
Copy link
Contributor

Merged build finished.

@tribler-ci
Copy link
Contributor

Test FAILed.
Refer to this link for build results: http://jenkins.tribler.org/job/GH_Tribler_pull-request-tester_devel/3423/

@whirm
Copy link

whirm commented Feb 17, 2015

retest this please

@corpaul
Copy link
Author

corpaul commented Feb 17, 2015

retest this please

@tribler-ci
Copy link
Contributor

Merged build triggered.

@tribler-ci
Copy link
Contributor

Merged build started.

@tribler-ci
Copy link
Contributor

Merged build triggered.

@tribler-ci
Copy link
Contributor

Merged build started.

@tribler-ci
Copy link
Contributor

Merged build finished.

@tribler-ci
Copy link
Contributor

Test FAILed.
Refer to this link for build results: http://jenkins.tribler.org/job/GH_Tribler_pull-request-tester_devel/3424/

@corpaul
Copy link
Author

corpaul commented Feb 17, 2015

retest this please

@tribler-ci
Copy link
Contributor

Merged build triggered.

@tribler-ci
Copy link
Contributor

Merged build started.

@tribler-ci
Copy link
Contributor

Merged build triggered.

@tribler-ci
Copy link
Contributor

Merged build started.

@tribler-ci
Copy link
Contributor

Merged build finished.

@tribler-ci
Copy link
Contributor

Test FAILed.
Refer to this link for build results: http://jenkins.tribler.org/job/GH_Tribler_pull-request-tester_devel/3425/

@tribler-ci
Copy link
Contributor

Merged build finished.

@tribler-ci
Copy link
Contributor

Test FAILed.
Refer to this link for build results: http://jenkins.tribler.org/job/GH_Tribler_pull-request-tester-isolated_devel/77/

@corpaul
Copy link
Author

corpaul commented Feb 18, 2015

retest this please

@tribler-ci
Copy link
Contributor

Merged build triggered.

@tribler-ci
Copy link
Contributor

Merged build started.

@tribler-ci
Copy link
Contributor

Merged build triggered.

@tribler-ci
Copy link
Contributor

Merged build started.

@tribler-ci
Copy link
Contributor

Merged build finished.

@tribler-ci
Copy link
Contributor

Merged build started.

@tribler-ci
Copy link
Contributor

Merged build finished.

@tribler-ci
Copy link
Contributor

Test FAILed.
Refer to this link for build results: http://jenkins.tribler.org/job/GH_Tribler_pull-request-tester_devel/3444/

@tribler-ci
Copy link
Contributor

Merged build finished.

@tribler-ci
Copy link
Contributor

Test FAILed.
Refer to this link for build results: http://jenkins.tribler.org/job/GH_Tribler_pull-request-tester-isolated_devel/96/

@tribler-ci
Copy link
Contributor

Merged build triggered.

@tribler-ci
Copy link
Contributor

Merged build started.

@tribler-ci
Copy link
Contributor

Merged build triggered.

@tribler-ci
Copy link
Contributor

Merged build started.

@tribler-ci
Copy link
Contributor

Merged build finished.

@tribler-ci
Copy link
Contributor

Test FAILed.
Refer to this link for build results: http://jenkins.tribler.org/job/GH_Tribler_pull-request-tester_devel/3446/

@tribler-ci
Copy link
Contributor

Merged build finished.

@tribler-ci
Copy link
Contributor

Test PASSed.
Refer to this link for build results: http://jenkins.tribler.org/job/GH_Tribler_pull-request-tester-isolated_devel/98/

whirm
whirm reviewed Feb 18, 2015
View reviewed changes
Tribler/community/bartercast4/community.py
# send back stats-response
self.create_stats_response(message.payload.stats_type, message.candidate)

# todo
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this go?

@whirm
Copy link

whirm commented Feb 18, 2015

@corpaul I think it would be nice to have some tests for this. Do you think you will have time to do it before next week?
@synctext: If @corpaul can't make it. Should we merge this without having tests for it so the students can work on it or?

@whirm whirm added the feedback label Feb 18, 2015
@whirm whirm added this to the V6.5 milestone Feb 18, 2015
@synctext
Copy link
Member

@whirm if it passes and you find the coding approach acceptable, it can be merged. Please bug Corpaul or create ticket for a test of this.

@tribler-ci
Copy link
Contributor

Merged build triggered.

@tribler-ci
Copy link
Contributor

Merged build started.

@tribler-ci
Copy link
Contributor

Merged build triggered.

@tribler-ci
Copy link
Contributor

Merged build started.

@tribler-ci
Copy link
Contributor

Merged build finished.

@tribler-ci
Copy link
Contributor

Test PASSed.
Refer to this link for build results: http://jenkins.tribler.org/job/GH_Tribler_pull-request-tester_devel/3450/

@tribler-ci
Copy link
Contributor

Merged build finished.

@tribler-ci
Copy link
Contributor

Test PASSed.
Refer to this link for build results: http://jenkins.tribler.org/job/GH_Tribler_pull-request-tester-isolated_devel/103/

whirm added a commit that referenced this pull request Feb 18, 2015
@whirm
Merge pull request #1230 from corpaul/bartercast_refactor
f78d7d0 
Bartercast statistics community
@whirm whirm merged commit f78d7d0 into Tribler:devel Feb 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
V6.5
Development

Successfully merging this pull request may close these issues.
4 participants
@corpaul @tribler-ci @whirm @synctext