-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anonymous Tribler Test #581
Conversation
Test FAILED. |
Test FAILED. |
Test FAILED. |
Seems that the Python Mock stuff is not working on the PR tester, will investigate tomorrow. |
Test FAILED. |
@@ -664,6 +670,28 @@ def set_preferred_playback_mode(self, mode): | |||
""" | |||
self.sessconfig.set(u'video', u'preferredmode', mode) | |||
|
|||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change this to be similar to set_libtorrent_proxy_settings and get_libtorrent_proxy_settings.
Test FAILED. |
@Devristo You forgot to add the sessions to self.sessions. That's probably why the unit tests hang. |
Will check it out |
Test FAILED. |
Just add a |
Test FAILED. |
Test FAILED. |
Test FAILED. |
Test PASSED. |
diff = time() - now | ||
self._logger.info("tribler: communities are ready in %.2f seconds", diff) | ||
|
||
s.set_proxy_community_socks5_listen_port(s.get_proxy_community_socks5_listen_port()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unneeded, simply pass s.get_proxy_community_socks5_listen_port() to the set_anon_proxy_settings
This can be seen as just one passing pull request |
😄 the two remaining issues I posted above are so small, I'm confident we're going to merged tomorrow. |
Test FAILED. |
Retest thuis please |
Retest this please |
@Devristo I can't make out if the download was anonymous or not, but it seems to not be: |
I think that is an ui bug (the -1). Perhaps better to make a screenshot of the anonymous panel, although it has a small issue as well, on low res screens |
Just add another screenshot, just use
to switch to the anonymity tab, and make a screenshot. |
Will do! Op 13 mei 2014 10:03 schreef NielsZeilemaker notifications@github.com:
to switch to the anonymity tab, and make a screenshot. Reply to this email directly or view it on GitHub: |
|
||
class TestAnonTunnelCommunity(TestGuiAsServer): | ||
|
||
def test_libtorrent_download(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Devristo could you rename the test? Maybe test_anon_download
Test PASSED. |
@egbertbouman the anonymous label of a torrent in the download list seems broken. I can fix it but I remember you telling me that it had to be done different for the release. What should I do ? |
Lets leave that for now, @egbertbouman will do some gui changes regardless |
It looks like the code that sets the anonymous label has disappeared from this branch. Will fix it once the PR is merged. |
=D |
Anonymity community
On startup circuits are created (quantity, length &c customizable). Test download will be added and downloaded through the tunnels.
todo