Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anonymous Tribler Test #581

Merged
merged 22 commits into from May 13, 2014
Merged

Anonymous Tribler Test #581

merged 22 commits into from May 13, 2014

Conversation

Devristo
Copy link
Contributor

@Devristo Devristo commented May 8, 2014

Anonymity community

On startup circuits are created (quantity, length &c customizable). Test download will be added and downloaded through the tunnels.

todo

  • GUI: [ egbert? ]
    • Anonymity panel available through button at anon download
    • Swarm panel in download details
  • Crawler testing [ in progress ]
  • Test download continuation on broken circuits [ tested // works ]

@tribler-ci
Copy link
Contributor

Test FAILED.
Refer to this link for build results: http://jenkins.tribler.org/job/GH_Tribler_pull-request-tester_devel/1984/

@tribler-ci
Copy link
Contributor

Test FAILED.
Refer to this link for build results: http://jenkins.tribler.org/job/GH_Tribler_pull-request-tester_devel/1985/

@tribler-ci
Copy link
Contributor

Test FAILED.
Refer to this link for build results: http://jenkins.tribler.org/job/GH_Tribler_pull-request-tester_devel/1986/

@synctext synctext mentioned this pull request May 8, 2014
@Devristo
Copy link
Contributor Author

Devristo commented May 8, 2014

Seems that the Python Mock stuff is not working on the PR tester, will investigate tomorrow.

@tribler-ci
Copy link
Contributor

Test FAILED.
Refer to this link for build results: http://jenkins.tribler.org/job/GH_Tribler_pull-request-tester_devel/1988/

@@ -664,6 +670,28 @@ def set_preferred_playback_mode(self, mode):
"""
self.sessconfig.set(u'video', u'preferredmode', mode)

#
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to be similar to set_libtorrent_proxy_settings and get_libtorrent_proxy_settings.

@tribler-ci
Copy link
Contributor

Test FAILED.
Refer to this link for build results: http://jenkins.tribler.org/job/GH_Tribler_pull-request-tester_devel/1989/

@egbertbouman
Copy link
Member

@Devristo You forgot to add the sessions to self.sessions. That's probably why the unit tests hang.

@Devristo
Copy link
Contributor Author

Will check it out

@tribler-ci
Copy link
Contributor

Test FAILED.
Refer to this link for build results: http://jenkins.tribler.org/job/GH_Tribler_pull-request-tester_devel/1992/

@egbertbouman
Copy link
Member

Just add a self.sessions.append(session) to line 45 of Tribler/Test/test_anontunnel_community.py.

@tribler-ci
Copy link
Contributor

Test FAILED.
Refer to this link for build results: http://jenkins.tribler.org/job/GH_Tribler_pull-request-tester_devel/1996/

@tribler-ci
Copy link
Contributor

Test FAILED.
Refer to this link for build results: http://jenkins.tribler.org/job/GH_Tribler_pull-request-tester_devel/1997/

@tribler-ci
Copy link
Contributor

Test FAILED.
Refer to this link for build results: http://jenkins.tribler.org/job/GH_Tribler_pull-request-tester_devel/1999/

@tribler-ci
Copy link
Contributor

Test PASSED.
Refer to this link for build results: http://jenkins.tribler.org/job/GH_Tribler_pull-request-tester_devel/2000/

diff = time() - now
self._logger.info("tribler: communities are ready in %.2f seconds", diff)

s.set_proxy_community_socks5_listen_port(s.get_proxy_community_socks5_listen_port())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unneeded, simply pass s.get_proxy_community_socks5_listen_port() to the set_anon_proxy_settings

@synctext
Copy link
Member

This can be seen as just one passing pull request
or a deadly salvo in the battle for control of The Internet...

@NielsZeilemaker
Copy link
Contributor

😄 the two remaining issues I posted above are so small, I'm confident we're going to merged tomorrow.

@tribler-ci
Copy link
Contributor

Test FAILED.
Refer to this link for build results: http://jenkins.tribler.org/job/GH_Tribler_pull-request-tester_devel/2003/

@Devristo
Copy link
Contributor Author

Retest thuis please

@Devristo
Copy link
Contributor Author

Retest this please

@NielsZeilemaker
Copy link
Contributor

@Devristo I can't make out if the download was anonymous or not, but it seems to not be:

@Devristo
Copy link
Contributor Author

I think that is an ui bug (the -1). Perhaps better to make a screenshot of the anonymous panel, although it has a small issue as well, on low res screens

@NielsZeilemaker
Copy link
Contributor

Just add another screenshot, just use

self.guiUtility.ShowPage

to switch to the anonymity tab, and make a screenshot.

@Devristo
Copy link
Contributor Author

Will do!

Op 13 mei 2014 10:03 schreef NielsZeilemaker notifications@github.com:
Just add another screenshot, just use

self.guiUtility.ShowPage

to switch to the anonymity tab, and make a screenshot.


Reply to this email directly or view it on GitHub:
#581 (comment)


class TestAnonTunnelCommunity(TestGuiAsServer):

def test_libtorrent_download(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Devristo could you rename the test? Maybe test_anon_download

@tribler-ci
Copy link
Contributor

Test PASSED.
Refer to this link for build results: http://jenkins.tribler.org/job/GH_Tribler_pull-request-tester_devel/2004/

@Devristo
Copy link
Contributor Author

@egbertbouman the anonymous label of a torrent in the download list seems broken. I can fix it but I remember you telling me that it had to be done different for the release. What should I do ?

@NielsZeilemaker
Copy link
Contributor

Lets leave that for now, @egbertbouman will do some gui changes regardless

@egbertbouman
Copy link
Member

It looks like the code that sets the anonymous label has disappeared from this branch. Will fix it once the PR is merged.

synctext added a commit that referenced this pull request May 13, 2014
@synctext synctext merged commit 46c3d2c into Tribler:devel May 13, 2014
@Devristo
Copy link
Contributor Author

=D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants