Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MusicDAO: Bitcoinj integration #47

Merged
merged 9 commits into from
Aug 31, 2020
Merged

MusicDAO: Bitcoinj integration #47

merged 9 commits into from
Aug 31, 2020

Conversation

Tim-W
Copy link
Contributor

@Tim-W Tim-W commented Aug 24, 2020

Integrated bitcoinJ library to the music app:

  • In-music-app wallet screen to view your status, public key, funds
  • Synchronizing the chain
  • From now on, whenever a person submits a new album/EP/single, his/her wallet public key is added to the trustchain block, so that other users can send money. Therefore only newly made releases after this 'protocol upgrade' will have a tip/donate button
  • Sending $1 tips to the artist directly from a playlist
  • Direct conversion of USD/BTC as a helper for the user (obviously using an external API so this might be removed for "fully distributed" cleanness)

No real device-to-device bitcoin transactions tested yet, as BTC transaction fees are high, up for discussion tomorrow :P

@Tim-W Tim-W mentioned this pull request Aug 24, 2020
Closed
@Tim-W Tim-W changed the title Bitcoinj integration MusicDAO: Bitcoinj integration Aug 25, 2020
Tim-W
Tim-W commented Aug 25, 2020
View reviewed changes
Copy link
Contributor Author

@Tim-W Tim-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to do some bug hunting to fix crashes

@Tim-W Tim-W merged commit 7d5a099 into Tribler:master Aug 31, 2020
Cornul11 pushed a commit to kponichtera/trustchain-superapp that referenced this pull request Feb 28, 2022
@xoriole
Merge pull request Tribler#47 from xoriole/fix/remove_bintray
ca700dd 
Replace bintray dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Tim-W